feat(Assignments): Send notifications for assignment events#539
Open
marcelklehr wants to merge 4 commits into
Open
feat(Assignments): Send notifications for assignment events#539marcelklehr wants to merge 4 commits into
marcelklehr wants to merge 4 commits into
Conversation
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds user notifications for “assignment” lifecycle events coming from ChattyLLM task processing, by emitting new notification subjects and teaching the app notifier how to render them.
Changes:
- Added
NotificationService::sendAssignmentNotification()to create assignment-related notifications tied to a chat session. - Extended
lib/Notification/Notifier.phpto render three new notification subjects: approval pending, successful, and failure. - Triggered assignment notifications from
ChattyLLMTaskListenerwhen a session is linked to an assignment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lib/Service/NotificationService.php | Introduces a new method for emitting assignment-related notifications based on task/session state. |
| lib/Notification/Notifier.php | Adds notification rendering (subject/message/link/action) for new assignment notification subjects. |
| lib/Listener/ChattyLLMTaskListener.php | Sends assignment notifications when a ChattyLLM task finishes and the session is linked to an assignment. |
Comments suppressed due to low confidence (2)
lib/Notification/Notifier.php:372
- For translations, prefer positional placeholders (e.g.
%1$s) instead of%sso translators can reorder arguments when needed. This message should use a numbered placeholder for the session title.
$message = $l->t('"%s" was run successfully.', [$params['sessionTitle']]);
lib/Notification/Notifier.php:397
- For translations, prefer positional placeholders (e.g.
%1$s) instead of%sso translators can reorder arguments when needed. This message should use a numbered placeholder for the session title.
$message = $l->t('"%s" failed to run.', [$params['sessionTitle']]);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
0cd303e to
6f99631
Compare
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.