Skip to content

feat(Assignments): Send notifications for assignment events#539

Open
marcelklehr wants to merge 4 commits into
mainfrom
feat/assignment-notify
Open

feat(Assignments): Send notifications for assignment events#539
marcelklehr wants to merge 4 commits into
mainfrom
feat/assignment-notify

Conversation

@marcelklehr
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds user notifications for “assignment” lifecycle events coming from ChattyLLM task processing, by emitting new notification subjects and teaching the app notifier how to render them.

Changes:

  • Added NotificationService::sendAssignmentNotification() to create assignment-related notifications tied to a chat session.
  • Extended lib/Notification/Notifier.php to render three new notification subjects: approval pending, successful, and failure.
  • Triggered assignment notifications from ChattyLLMTaskListener when a session is linked to an assignment.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
lib/Service/NotificationService.php Introduces a new method for emitting assignment-related notifications based on task/session state.
lib/Notification/Notifier.php Adds notification rendering (subject/message/link/action) for new assignment notification subjects.
lib/Listener/ChattyLLMTaskListener.php Sends assignment notifications when a ChattyLLM task finishes and the session is linked to an assignment.
Comments suppressed due to low confidence (2)

lib/Notification/Notifier.php:372

  • For translations, prefer positional placeholders (e.g. %1$s) instead of %s so translators can reorder arguments when needed. This message should use a numbered placeholder for the session title.
				$message = $l->t('"%s" was run successfully.', [$params['sessionTitle']]);

lib/Notification/Notifier.php:397

  • For translations, prefer positional placeholders (e.g. %1$s) instead of %s so translators can reorder arguments when needed. This message should use a numbered placeholder for the session title.
				$message = $l->t('"%s" failed to run.', [$params['sessionTitle']]);


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/Service/NotificationService.php
Comment thread lib/Notification/Notifier.php
Comment thread lib/Listener/ChattyLLMTaskListener.php
Comment thread lib/Listener/ChattyLLMTaskListener.php
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the feat/assignment-notify branch from 0cd303e to 6f99631 Compare May 13, 2026 06:04
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants