Skip to content

fix(manual-install): prevent duplicate port in ExApp URLs #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 1 commit into from
Jan 19, 2026
Merged

fix(manual-install): prevent duplicate port in ExApp URLs #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/Command/Daemon/RegisterDaemon.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
return 1;
}

if ($acceptsDeployId === 'manual-install' && !$isHarp && str_contains($host, ':')) {
$output->writeln('<comment>Warning: The host contains a port, which will be ignored for manual-install daemons. The ExApp\'s port from --json-info will be used instead.</comment>');
}

if ($this->daemonConfigService->getDaemonConfigByName($name) !== null) {
$output->writeln(sprintf('Registration skipped, as the daemon config `%s` already exists.', $name));
return 0;
Expand Down
1 change: 1 addition & 0 deletions lib/DeployActions/ManualActions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public function resolveExAppUrl(
$host = $deployConfig['additional_options']['OVERRIDE_APP_HOST'];
}
}
$host = explode(':', $host)[0];
return sprintf('%s://%s:%s', $protocol, $host, $port);
}
}