Skip to content

fix(docker-registry-override): change NcButton to NcActionButton #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 1 commit into from
Jan 13, 2026
+6 −5
Merged

fix(docker-registry-override): change NcButton to NcActionButton #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/app_api-adminSettings.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/app_api-adminSettings.js.map
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions src/components/DaemonConfig/DockerRegistriesModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,15 @@
<span style="color: var(--color-warning);">{{ t('app_api', 'Image pull will be skipped') }}</span>
</template>
<template #actions>
<NcButton
variant="icon"
<NcActionButton
:disabled="removingRegistryLoading"
@click="removeDockerRegistry(registry)">
<template #icon>
<NcLoadingIcon v-if="removingRegistryLoading" :size="20" />
<Close v-else :size="20" />
</template>
{{ t('app_api', 'Remove') }}
</NcButton>
</NcActionButton>
</template>
</NcListItem>
</div>
Expand Down Expand Up @@ -127,6 +126,7 @@ import NcNoteCard from '@nextcloud/vue/components/NcNoteCard'
import NcTextField from '@nextcloud/vue/components/NcTextField'
import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
import NcListItem from '@nextcloud/vue/components/NcListItem'
import NcActionButton from '@nextcloud/vue/components/NcActionButton'

import NcLoadingIcon from '@nextcloud/vue/components/NcLoadingIcon'
import Docker from 'vue-material-design-icons/Docker.vue'
Expand All @@ -144,6 +144,7 @@ export default {
NcTextField,
NcEmptyContent,
NcListItem,
NcActionButton,
Docker,
Plus,
Check,
Expand Down
Loading