Skip to content

BugFix - Filter Only One TextInput and one TextOutput Task Types #15079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 5 commits into from
Jul 2, 2025
Merged

BugFix - Filter Only One TextInput and one TextOutput Task Types #15079

tobiasKaminsky merged 5 commits into from
Jul 2, 2025

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jul 1, 2025 •
edited
Loading

  • Tests written, or not not needed

Library PR: nextcloud/android-library#1761

How to test?

  1. Set up two instances: one with Nextcloud 28 and another with Nextcloud version 30 or higher.
  2. Enable assistant app from web client
  3. Create a task and user should not be able to see the Chat task type.

@alperozturk96 alperozturk96 mentioned this pull request Jul 1, 2025
Merged
@alperozturk96 alperozturk96 requested a review from ZetaTom July 1, 2025 12:01
@alperozturk96 alperozturk96 force-pushed the bugfix/filter-chat-type-assistant branch from 4cf2f6f to 52a766c Compare July 2, 2025 07:02
@tobiasKaminsky tobiasKaminsky linked an issue Jul 2, 2025 that may be closed by this pull request
Assistant chat breaks: An error occurred while creating the task #14689
Closed
4 tasks
tobiasKaminsky
tobiasKaminsky reviewed Jul 2, 2025
View reviewed changes
@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jul 2, 2025

/backport to stable-3.32

@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.32.0 milestone Jul 2, 2025
@alperozturk96
update lib
0a52b43 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
check emptiness instead of nullability
f0f397c 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update lib
2f4db98 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix tests
7a2bd47 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/filter-chat-type-assistant branch from 9e1e63a to 7a2bd47 Compare July 2, 2025 11:14
@alperozturk96
update libs
bfafd7f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15079.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Codacy

Lint

TypemasterPR
Warnings5150
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness6262
Dodgy code300300
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total538538

@tobiasKaminsky tobiasKaminsky merged commit ce0f466 into master Jul 2, 2025
18 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bugfix/filter-chat-type-assistant branch July 2, 2025 12:59
@backportbot backportbot bot mentioned this pull request Jul 2, 2025
Merged
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.32.0

Development

Successfully merging this pull request may close these issues.

Assistant chat breaks: An error occurred while creating the task

3 participants

@alperozturk96 @tobiasKaminsky