Skip to content

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 30, 2025

  • Tests written, or not not needed

Library PR: nextcloud/android-library#1758

Issue

Since Nextcloud 30, the enabled key have been renamed to value and supports more than boolean. Thus, client needs to support both type.

Documentation

How to test?

Scenario 1: Updating an Existing Share

  1. Set up two instances: one with Nextcloud 28 and another with Nextcloud version 30 or higher.
  2. Create a share on both instances.
  3. Update the share settings to enable "Allow download and sync."
  4. Ensure the update is successfully completed.

Scenario 2: Creating a Share with Specific Permissions

  1. Set up two instances: one with Nextcloud 28 and another with Nextcloud version 30 or higher.
  2. Create a share with "Allow download and sync" enabled.
  3. Verify that the share is successfully created.

@alperozturk96 alperozturk96 changed the title BugFix - Use BugFix - Use Correct Download Attribute Jun 30, 2025
@alperozturk96 alperozturk96 force-pushed the bugfix/use-correct-download-attribute branch from 9e00615 to c38a4d2 Compare July 1, 2025 07:12
@alperozturk96 alperozturk96 requested a review from ZetaTom July 1, 2025 08:16
@alperozturk96 alperozturk96 force-pushed the bugfix/use-correct-download-attribute branch from 1595425 to 7076746 Compare July 2, 2025 12:46
@nextcloud nextcloud deleted a comment from github-actions bot Jul 2, 2025
@alperozturk96 alperozturk96 force-pushed the bugfix/use-correct-download-attribute branch from 7076746 to b394698 Compare July 4, 2025 09:38
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/use-correct-download-attribute branch from 3fc7908 to cdc7cd1 Compare July 7, 2025 07:09
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Codacy

Lint

TypemasterPR
Warnings5150
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness6262
Dodgy code300300
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total538538

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15074.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

@alperozturk96
Copy link
Collaborator Author

replaced via #15107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants