Skip to content

Conversation

@xavi-b
Copy link
Contributor

@xavi-b xavi-b commented Jun 7, 2025

Adding missing cases for federated groups
It goes with the following pull request in android-library : nextcloud/android-library#1739

@AndyScherzinger AndyScherzinger added enhancement 3. to review feature: sharing Excluding: Sharing to/from the app from other Android apps labels Jun 7, 2025
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@tobiasKaminsky
Copy link
Member

It works, in terms of adding a federated group.
But I cannot see an Icon:
image

sharees in OCFile is empty.

@tobiasKaminsky
Copy link
Member

Tested and works ✔

Shall I rebase and fix the conflict?

@xavi-b
Copy link
Contributor Author

xavi-b commented Sep 3, 2025

Yes please 😊

@tobiasKaminsky tobiasKaminsky mentioned this pull request Sep 9, 2025
1 task
@tobiasKaminsky
Copy link
Member

I could not push to your branch, thus I created: #15588

@tobiasKaminsky
Copy link
Member

Many thanks for your PR! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement feature: sharing Excluding: Sharing to/from the app from other Android apps feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants