Skip to content

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 25, 2025

  • Tests written, or not not needed

Library PR: nextcloud/android-library#1672
Issue: #14517

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.13%. Comparing base (cbec4a1) to head (71e4040).

Files with missing lines Patch % Lines
...ties/data/activities/ActivitiesServiceApiImpl.java 0.00% 1 Missing ⚠️
...roid/ui/fragment/FileDetailActivitiesFragment.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14727      +/-   ##
============================================
- Coverage     24.20%   24.13%   -0.07%     
  Complexity     3329     3329              
============================================
  Files           697      697              
  Lines         51268    51268              
  Branches       6909     6909              
============================================
- Hits          12409    12375      -34     
- Misses        36926    36980      +54     
+ Partials       1933     1913      -20     
Files with missing lines Coverage Δ
...loud/android/ui/activities/ActivitiesActivity.java 0.00% <ø> (ø)
...oud/android/ui/activities/ActivitiesPresenter.java 0.00% <ø> (ø)
...es/data/activities/RemoteActivitiesRepository.java 0.00% <ø> (ø)
...ties/data/activities/ActivitiesServiceApiImpl.java 0.00% <0.00%> (ø)
...roid/ui/fragment/FileDetailActivitiesFragment.java 43.66% <0.00%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alperozturk96 alperozturk96 force-pushed the bugfix/use-long-for-last-given branch 3 times, most recently from f5d01b0 to 4dd6e2e Compare April 10, 2025 06:38
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/use-long-for-last-given branch from ac7f5ad to 8f08047 Compare April 10, 2025 14:09
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code292292
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total500500

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14727.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit b5c3663 into master Apr 11, 2025
20 checks passed
@alperozturk96 alperozturk96 deleted the bugfix/use-long-for-last-given branch April 11, 2025 06:57
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.32.0 milestone May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants