Skip to content

Feature - Use default sharing permissions #14695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 6 commits into from
Apr 3, 2025
Merged

Feature - Use default sharing permissions #14695

tobiasKaminsky merged 6 commits into from
Apr 3, 2025

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 17, 2025 •
edited
Loading

  • Tests written, or not not needed

Library PR: nextcloud/android-library#1688

Feature Issue: nextcloud/files-clients#4

How to test?

  1. Create a share without choosing any share permission (View only, Allow upload and editing, File drop (upload only))
  2. Via debugger determine what's the default permission int value
  3. Open web app and navigate to the "apps/files/shareoverview"
  4. Observe response of "ocs/v2.php/apps/files_sharing/api/v1/shares?shared_with_me=false&include_tags=true"
  5. Compare the permission field inside the data with the default permission value sent from the application.

@alperozturk96 alperozturk96 mentioned this pull request Mar 17, 2025
Closed
3 tasks
@alperozturk96 alperozturk96 force-pushed the feature/use-default-sharing-permissions branch from 945a821 to 5a96dc0 Compare March 18, 2025 11:13
@alperozturk96 alperozturk96 mentioned this pull request Mar 18, 2025
Merged
@alperozturk96 alperozturk96 force-pushed the feature/use-default-sharing-permissions branch 2 times, most recently from 8c27a43 to cc26b20 Compare April 2, 2025 09:14
@alperozturk96
add PROPERTY_DEFAULT_PERMISSIONS
a4dedfd 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use default permission
24defbc 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use default permission
ac36c62 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update lib
20810d4 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the feature/use-default-sharing-permissions branch from cc26b20 to 20810d4 Compare April 2, 2025 13:52
@alperozturk96
update android lib
e5905f5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update android lib
e36a0d5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code292292
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total500500

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14695.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14695-Screenshot-blue-Light-14-25

@tobiasKaminsky tobiasKaminsky linked an issue Apr 3, 2025 that may be closed by this pull request
Use default sharing permissions from server #7604
Closed
@tobiasKaminsky tobiasKaminsky merged commit bcc5faf into master Apr 3, 2025
17 of 20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the feature/use-default-sharing-permissions branch April 3, 2025 06:59
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.32.0 milestone May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.32.0

Development

Successfully merging this pull request may close these issues.

Use default sharing permissions from server

3 participants

@alperozturk96 @tobiasKaminsky