Skip to content

Show avatars in activity list #14634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tobiasKaminsky wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Show avatars in activity list #14634

tobiasKaminsky wants to merge 2 commits into from
+311 −28

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Mar 5, 2025

  • Tests written, or not not needed

@tobiasKaminsky tobiasKaminsky mentioned this pull request Feb 26, 2025
Open
2 tasks
@tobiasKaminsky tobiasKaminsky linked an issue Mar 5, 2025 that may be closed by this pull request
Show avatars in notifications and activity (like in server) #14597
Open
2 tasks
@tobiasKaminsky tobiasKaminsky linked an issue Jun 26, 2025 that may be closed by this pull request
Show avatars in notifications and activity (like in server) nextcloud/server#16207
Open
4 tasks
@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review November 21, 2025 06:38
ZetaTom
ZetaTom requested changes Jan 8, 2026
View reviewed changes
Copy link
Collaborator

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in general with some issues. Please implement the changes I suggested.

Filenames in file details also appear red with this change in place - see following screenshot on the right.

image

Sometimes avatars aren't rendered correctly and the placeholder is cut off. The user account Charlie has an avatar set, which is correctly displayed elsewhere.

Untitled

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Jan 22, 2026

@ZetaTom red filename and avatar size fixed.

@alperozturk96 alperozturk96 added this to the Nextcloud App 3.36.0 milestone Feb 4, 2026
@tobiasKaminsky @alperozturk96
Show avatars in activity list
7ad1bc5 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
alperozturk96
alperozturk96 requested changes Feb 4, 2026
View reviewed changes
Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared user name is not displaying correctly and the UI gets stuck in a loading state.

Screen.Recording.2026-02-04.at.09.36.34.mov

Codacy

Image

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Feb 11, 2026 •
edited
Loading

probably recycler view problem: set has stable ids -> true?

new issue: adding comment not displayed/ refreshed in android

@tobiasKaminsky
fix npe
26ed430 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4243
Correctness7574
Dodgy code256258
Experimental11
Internationalization77
Malicious code vulnerability23
Multithreaded correctness3434
Performance4443
Security1818
Total479481

SpotBugs increased!

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14634.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 requested changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud App 3.36.0

Development

Successfully merging this pull request may close these issues.

Show avatars in notifications and activity (like in server) Show avatars in notifications and activity (like in server)

4 participants

@tobiasKaminsky @alperozturk96 @ZetaTom @AndyScherzinger