Skip to content

Conversation

@ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Jan 15, 2025

This change adds support for the files_downloadlimit server app which allows users to set limit of how many times a file may be downloaded from a public share.

A corresponding pull request which implements all required interfaces has been opened as nextcloud/android-library#1631

See nextcloud/files-clients#54 for more information.

Screenshots

Share Details Share Settings
filesdownloadlimit_share_list filesdownloadlimit_share_settings

@ZetaTom ZetaTom self-assigned this Jan 15, 2025
@ZetaTom ZetaTom linked an issue Jan 15, 2025 that may be closed by this pull request
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.31.0 milestone Jan 21, 2025
@tobiasKaminsky
Copy link
Member

@ZetaTom library branch is merged

@ZetaTom ZetaTom force-pushed the feature/file_download_limits branch 3 times, most recently from a610562 to 19ccf14 Compare January 22, 2025 08:48
ZetaTom and others added 19 commits January 22, 2025 10:33
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
@ZetaTom ZetaTom force-pushed the feature/file_download_limits branch from 19ccf14 to a3ab2f4 Compare January 22, 2025 11:00
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14412.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total504504

@tobiasKaminsky tobiasKaminsky merged commit 1ade346 into master Jan 22, 2025
21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the feature/file_download_limits branch January 22, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support File Download Limits

4 participants