Skip to content

Feature - Copy, Share, Edit Assistant #14115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 34 commits into from
Dec 11, 2024
Merged

Feature - Copy, Share, Edit Assistant #14115

tobiasKaminsky merged 34 commits into from
Dec 11, 2024

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Dec 2, 2024 •
edited
Loading

  • Tests written, or not not needed

Changes

  • Design updated
  • Copy, Share, Edit feature added
  • Task completion time added

Screenshot_20241206_094310
Screenshot_20241206_094320
Screenshot_20241206_094346

@alperozturk96 alperozturk96 changed the title Feature - Copy share edit assistant Feature - Copy Share, Edit Assistant Dec 2, 2024
@alperozturk96 alperozturk96 marked this pull request as draft December 2, 2024 14:02
@alperozturk96 alperozturk96 force-pushed the feature/copy-share-edit-assistant branch from 984b45c to e1d5413 Compare December 3, 2024 08:25
@alperozturk96 alperozturk96 force-pushed the feature/copy-share-edit-assistant branch from 3b0e56f to 2dd43bc Compare December 4, 2024 10:09
@nextcloud nextcloud deleted a comment from github-actions bot Dec 4, 2024
@alperozturk96 alperozturk96 marked this pull request as ready for review December 4, 2024 11:13
@alperozturk96 alperozturk96 changed the title Feature - Copy Share, Edit Assistant Feature - Copy, Share, Edit Assistant Dec 6, 2024
@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Dec 9, 2024

Small things

  • copy says "link copied"
  • "Add New Task" -> all capitalized
  • share/copy text is only answer. I think sharing everything is better.
  • three dot menu in detail view closes detail view, that feels a bit strange?

@tobiasKaminsky tobiasKaminsky force-pushed the feature/copy-share-edit-assistant branch from 014581c to 8a728c5 Compare December 9, 2024 07:57
@alperozturk96 alperozturk96 force-pushed the feature/copy-share-edit-assistant branch from 8a728c5 to 7973bd4 Compare December 9, 2024 11:06
@nextcloud nextcloud deleted a comment from github-actions bot Dec 9, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Dec 9, 2024
@alperozturk96
Change UI according to the latest adjustments
7be3938 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add task actions
e2fc6a7 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add TaskActions
9de9f0d 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add actions
b8055bc 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
clear unnecessary logic
623ff84 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
complete more actions
a4c36f1 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add more actions to the detail view
8f71899 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
modal bottom sheet appereance fix
bab98b4 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Handle states better
baba9e0 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add time completion to the task status
d620123 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
adopt latest api changes
f7bfaa5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
only use text context
ded9384 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix add operation
312e793 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
remove combined click
4796b67 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Use task types for create operation
ac3c735 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use response key for id
21ef735 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix bottom sheet title appereance
2ca151d 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix code analytics
51b5add 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update library
8f69816 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
decouple business logic from the ui
92c99b2 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update tests
3cffeee 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Create DateFormatter extract date related logic from Task extensions
8d4a34c 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Get rid of unncessary state for task view
06af708 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
remove unused keys
fb087b5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
remove unused icon for assistant (lint warning)
e0ac903 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix code analytics
41b06cc 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use native tab layout
561c6d1 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix colors
0d53be7 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix colors
98529dc 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix code analytics
54cc4f8 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update library
06b8db9 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use input and output together for share and copy
2d53e53 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
change title of the add new task
9801624 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
update ss
ddcd223 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the feature/copy-share-edit-assistant branch from 82c0047 to ddcd223 Compare December 10, 2024 13:14
@github-actions
Copy link

github-actions bot commented Dec 10, 2024

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code299299
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total509509

@tobiasKaminsky tobiasKaminsky merged commit d5a9123 into master Dec 11, 2024
20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the feature/copy-share-edit-assistant branch December 11, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

🤖 🍏 Mobile clients team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alperozturk96 @tobiasKaminsky