Skip to content

Drop NC19 #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 1 commit into from
Oct 20, 2025
Merged

Drop NC19 #1813

tobiasKaminsky merged 1 commit into from
Oct 20, 2025

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Aug 28, 2025

No description provided.

@tobiasKaminsky tobiasKaminsky mentioned this pull request Aug 28, 2025
Closed
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@tobiasKaminsky tobiasKaminsky force-pushed the dropNC19 branch 3 times, most recently from c8d8678 to 904c5e4 Compare August 28, 2025 05:25
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 28, 2025

@tobiasKaminsky looking at the original if statements you should be keeping the if branch not the else branch, no?

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Aug 28, 2025

@tobiasKaminsky looking at the original if statements you should be keeping the if branch not the else branch, no

you are right!

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Sep 3, 2025

Fixed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Sep 3, 2025

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4466-IT-stable-10-33/debug/

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Sep 3, 2025

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4466-IT-master-10-34/debug/

alperozturk96

This comment was marked as outdated.

Sign in to view

@tobiasKaminsky
Drop NC19
2c6acca 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Oct 20, 2025

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4584-IT-stable-07-36/debug/

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Oct 20, 2025

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4584-IT-master-07-36/debug/

@tobiasKaminsky tobiasKaminsky merged commit b0e14ef into master Oct 20, 2025
16 of 17 checks passed
@tobiasKaminsky tobiasKaminsky deleted the dropNC19 branch October 20, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tobiasKaminsky @AndyScherzinger @nextcloud-android-bot @alperozturk96