Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 63.21839% with 64 lines in your changes missing coverage. Please review.

Project coverage is 49.39%. Comparing base (eeff723) to head (c6a41f2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...id/lib/resources/files/CreateLocalFileException.kt 0.00% 8 Missing ⚠️
...main/java/com/nextcloud/common/OkHttpMethodBase.kt 12.50% 2 Missing and 5 partials ⚠️
...m/owncloud/android/lib/resources/status/Problem.kt 0.00% 5 Missing ⚠️
...cloud/android/lib/resources/shares/SharedWithMe.kt 0.00% 4 Missing ⚠️
.../main/java/com/nextcloud/common/ResponseOrError.kt 0.00% 3 Missing ⚠️
.../com/owncloud/android/lib/common/SearchProvider.kt 25.00% 3 Missing ⚠️
...droid/lib/resources/assistant/v1/model/TaskList.kt 0.00% 3 Missing ⚠️
...oud/android/lib/resources/e2ee/MetadataResponse.kt 0.00% 3 Missing ⚠️
...ud/android/lib/resources/files/model/RemoteFile.kt 0.00% 3 Missing ⚠️
...m/owncloud/android/lib/resources/shares/OCShare.kt 0.00% 3 Missing ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1623      +/-   ##
============================================
+ Coverage     49.27%   49.39%   +0.12%     
- Complexity     1035     1058      +23     
============================================
  Files           215      215              
  Lines          8088     8177      +89     
  Branches       1038     1040       +2     
============================================
+ Hits           3985     4039      +54     
- Misses         3534     3568      +34     
- Partials        569      570       +1     
Files with missing lines Coverage Δ
...ashboard/DashboardGetWidgetItemsRemoteOperation.kt 67.85% <100.00%> (+2.47%) ⬆️
...b/resources/files/ToggleFileLockRemoteOperation.kt 61.29% <100.00%> (+2.66%) ⬆️
...ces/groupfolders/GetGroupfoldersRemoteOperation.kt 60.00% <100.00%> (-1.30%) ⬇️
...b/resources/profile/GetHoverCardRemoteOperation.kt 60.00% <100.00%> (+2.85%) ⬆️
...b/resources/search/UnifiedSearchRemoteOperation.kt 68.08% <100.00%> (-0.67%) ⬇️
.../java/com/nextcloud/common/NextcloudUriDelegate.kt 90.00% <100.00%> (+2.50%) ⬆️
...c/main/java/com/nextcloud/common/SessionTimeOut.kt 100.00% <100.00%> (ø)
...rc/main/java/com/nextcloud/common/UserIdEncoder.kt 100.00% <100.00%> (ø)
...m/owncloud/android/lib/common/SearchResultEntry.kt 96.00% <100.00%> (ø)
...owncloud/android/lib/common/network/WebdavEntry.kt 82.51% <100.00%> (ø)
... and 40 more

... and 1 file with indirect coverage changes

@AndyScherzinger AndyScherzinger merged commit 3044318 into master Jan 8, 2025
20 checks passed
@AndyScherzinger AndyScherzinger deleted the spotlessFix branch January 8, 2025 10:18
@AndyScherzinger AndyScherzinger added this to the NC Android lib 2.20.0 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants