ToS

[tobiasKaminsky]

For nextcloud/android#14159

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[codecov]

Codecov Report

Attention: Patch coverage is 1.72414% with 57 lines in your changes missing coverage. Please review.

Project coverage is 22.61%. Comparing base (e3c0611) to head (f4f71d5).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
...droid/lib/resources/tos/GetTermsRemoteOperation.kt	0.00%	30 Missing ⚠️
...droid/lib/resources/tos/SignTermRemoteOperation.kt	0.00%	11 Missing ⚠️
...va/com/nextcloud/android/lib/resources/tos/Term.kt	0.00%	6 Missing ⚠️
...d/lib/common/operations/RemoteOperationResult.java	0.00%	5 Missing ⚠️
...a/com/nextcloud/android/lib/resources/tos/Terms.kt	0.00%	4 Missing ⚠️
...resources/files/ExistenceCheckRemoteOperation.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1604      +/-   ##
============================================
- Coverage     22.69%   22.61%   -0.08%     
- Complexity      633      640       +7     
============================================
  Files           222      226       +4     
  Lines          8407     8462      +55     
  Branches       1099     1105       +6     
============================================
+ Hits           1908     1914       +6     
- Misses         6305     6356      +51     
+ Partials        194      192       -2     

Files with missing lines	Coverage Δ
...android/lib/common/operations/ExceptionParser.java	70.83% <100.00%> (+2.74%)	⬆️
...resources/files/ExistenceCheckRemoteOperation.java	0.00% <0.00%> (ø)
...a/com/nextcloud/android/lib/resources/tos/Terms.kt	0.00% <0.00%> (ø)
...d/lib/common/operations/RemoteOperationResult.java	0.00% <0.00%> (ø)
...va/com/nextcloud/android/lib/resources/tos/Term.kt	0.00% <0.00%> (ø)
...droid/lib/resources/tos/SignTermRemoteOperation.kt	0.00% <0.00%> (ø)
...droid/lib/resources/tos/GetTermsRemoteOperation.kt	0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[tobiasKaminsky]

/backport to stable-2.20