feat(referencePicker): introduce getReferenceWithPicker()#8532
Open
mejo- wants to merge 2 commits into
Open
Conversation
mejo-
added
3. to review
Contributor
Author
|
/backport to stable8 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8532 +/- ##
==========================================
- Coverage 54.57% 54.31% -0.26%
==========================================
Files 106 106
Lines 3443 3461 +18
Branches 1004 1009 +5
==========================================
+ Hits 1879 1880 +1
- Misses 1323 1336 +13
- Partials 241 245 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/backport to stable8 |
mejo-
force-pushed
the
feat/reference_picker_return_object
branch
from
53cfef4 to
367d86b
Compare
mejo-
changed the title
max-nextcloud
approved these changes
May 18, 2026
mejo-
force-pushed
the
feat/reference_picker_return_object
branch
2 times, most recently
from
638da91 to
7113c3d
Compare
ShGKme
reviewed
May 18, 2026
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
If I understand the change correctly, the following components have changed public API:
NcReferencePickerNcSearch
Comment on lines
+53
to
+56
| const modalId = 'referencePickerModal' | ||
| const modalElement = document.createElement('div') | ||
| modalElement.id = modalId | ||
| document.body.append(modalElement) |
Contributor
There was a problem hiding this comment.
We have spawnDialog util to mount dialogs
| * @param providerId - Optional ID of initial selected provider | ||
| * @param isInsideViewer - Should be true if this function is called while the Viewer is displayed | ||
| */ | ||
| export async function getReferenceWithPicker(providerId?: string, isInsideViewer?: boolean): Promise<PickerSubmitResult> { |
Contributor
There was a problem hiding this comment.
Having isInsideViewer as a position parameter seems unexpected to me. Picker shouldn't know, it is it in Viewer. If it's really needed, I'd make it an option rather than a second position parameter.
Contributor
Author
There was a problem hiding this comment.
As written in 1:1 chat, I kept it that way to keep getLinkWithPicker() and getReferenceWithPicker() as similar as possible to make it a no-brainer to migrate from one to the other.
mejo-
force-pushed
the
feat/reference_picker_return_object
branch
2 times, most recently
from
481340b to
a4a1f78
Compare
Required for Text and Collectives to pass the link title from the picker (e.g. Collectives PagePicker.vue) to the consumer (menubar in Text). Signed-off-by: Jonas <jonas@freesources.org>
- In NcCustomPickerElement we cannot control the submitted type, so let's add the type check there as well. - NcSearch is exported publically and used by apps, so changing its return type would introduce a backwards-incompatibility. - NcProviderList, NcRawLinkInput and NcCustomPickerElement are not publically exposed, so we can change the emitted type there. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
feat/reference_picker_return_object
branch
from
a4a1f78 to
9e64b40
Compare
mejo-
added a commit
to nextcloud/text
that referenced
this pull request
May 18, 2026
Requires nextcloud-libraries/nextcloud-vue#8532 to have an effect. Signed-off-by: Jonas <jonas@freesources.org>
This was referenced May 18, 2026
Contributor
Author
|
nextcloud/text#8615 and nextcloud/collectives#2522 are the respective PRs in Text and Collectives to use this new feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for Text and Collectives to pass the link title from the picker (e.g. Collectives PagePicker.vue) to the consumer (menubar in Text).
🏁 Checklist
stable8for maintained Vue 2 version or not applicable