chore: modernize package and move to ESM package #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
ShGKme
reviewed
Jun 21, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/modernize-esm
branch
from
408140e to
bc6cef8
Compare
ShGKme
approved these changes
Jun 21, 2025
Comment on lines
+16
to
+21
| "exports": { | ||
| ".": { | ||
| "types": "./dist/index.d.ts", | ||
| "default": "./dist/index.js" | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
Or simply, as there are no subpaths:
Suggested change
| "exports": { | |
| ".": { | |
| "types": "./dist/index.d.ts", | |
| "default": "./dist/index.js" | |
| } | |
| }, | |
| "exports": "./dist/index.js", | |
| "types": "./dist/index.d.ts", |
Contributor
Author
There was a problem hiding this comment.
IIRC I had problems with such exports because types is not parsed correctly, so least this was needed:
"exports": {
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would require a new 0.5 release instead of a 0.4.1 release though...