Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 21, 2025

Maybe a very personal opinion, but I'd expect a file to have the same name (incl. casing) as the primary export in the module.

Especially to avoid errors from case-insensitive OS (Windows) (though it is handled by ESLint).

Alternative: kebab-case

@ShGKme ShGKme added the 3. to review Waiting for reviews label Jun 21, 2025
@susnux
Copy link
Contributor

susnux commented Jun 21, 2025

Especially to avoid errors from case-insensitive OS (Windows) (though it is handled by ESLint).

You are not enabling case sensitivity on Windows for git folders? 😉
(not sure people even know you can enable case sensitivity nowadays in Windows^^)

Not but apart from joking I agree with you, if you have modules with default exports they should be called the same.
I do not care if CamelCase or kebab-case though.

I think we use both mixed in our code base, but slightly I would prefer CamelCase as we do for components etc

@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 21, 2025

You are not enabling case sensitivity on Windows for git folders? 😉
(not sure people even know you can enable case sensitivity nowadays in Windows^^)

I develop on a remote Linux server for everything (except for Talk Desktop when doing desktop parts) 👀

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for the one import this is fine

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the chore/module-names branch from 3d48927 to 9663b13 Compare June 21, 2025 14:46
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 21, 2025

except for the one import this is fine

Fixed

@ShGKme ShGKme merged commit 54c9468 into main Jun 21, 2025
10 checks passed
@ShGKme ShGKme deleted the chore/module-names branch June 21, 2025 14:47
@susnux susnux mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants