Skip to content

LangChain Chain Model Reporting#1748

Open
TimPansino wants to merge 9 commits into
mainfrom
fix-langchain-chain-models
Open

LangChain Chain Model Reporting#1748
TimPansino wants to merge 9 commits into
mainfrom
fix-langchain-chain-models

Conversation

@TimPansino
Copy link
Copy Markdown
Contributor

Overview

  • Add a new strategy back to LangChain for capturing model attributes on chain invocations.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 8 0 0 0.9s
✅ MARKDOWN markdownlint 7 0 0 0 1.36s
✅ PYTHON ruff 1038 0 0 0 1.05s
✅ PYTHON ruff-format 1038 0 0 0 0.4s
✅ YAML prettier 20 0 0 0 1.66s
✅ YAML v8r 20 0 0 6.04s
✅ YAML yamllint 20 0 0 0.69s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 68.29268% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.03%. Comparing base (c972036) to head (cd81a1a).

Files with missing lines Patch % Lines
newrelic/hooks/mlmodel_langchain.py 68.29% 20 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
- Coverage   82.08%   82.03%   -0.06%     
==========================================
  Files         215      215              
  Lines       26324    26403      +79     
  Branches     4153     4169      +16     
==========================================
+ Hits        21609    21660      +51     
- Misses       3300     3321      +21     
- Partials     1415     1422       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmstepanek hmstepanek marked this pull request as ready for review June 1, 2026 21:06
@hmstepanek hmstepanek requested a review from a team as a code owner June 1, 2026 21:06
@hmstepanek hmstepanek self-requested a review June 1, 2026 21:06
@TimPansino TimPansino force-pushed the fix-langchain-chain-models branch from 4761cb3 to 56c873a Compare June 1, 2026 21:10
@mergify mergify Bot added the tests-failing Tests failing in CI. label Jun 2, 2026
Copy link
Copy Markdown
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to wrap my head around why we need this callback pattern but I really don't understand. Can't we just call the function where we need it after we get the response back instead of all this passing around of a handler callback function and class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-failing Tests failing in CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants