Skip to content

Conversation

@nev21
Copy link
Contributor

@nev21 nev21 commented Dec 30, 2025

Removed global git config commands for user name and email.

Removed global git config commands for user name and email.
Copilot AI review requested due to automatic review settings December 30, 2025 06:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the git config commands that set the user name and email for the dependabot-sync bot in the Rush version sync workflow.

Key Changes:

  • Removed git config --global user.name "dependabot-sync[bot]" command
  • Removed git config --global user.email "dependabot-sync[bot]@users.noreply.github.com" command
Comments suppressed due to low confidence (1)

.github/workflows/sync-rush-versions.yml:82

  • The removal of git config commands will cause the git commit command on line 80 to fail. Git requires user.name and user.email to be configured before making commits. Without these config values, the workflow will error with "Please tell me who you are" when attempting to commit.

The actions/checkout action does not automatically configure git user identity. You need to either:

  1. Keep the git config commands (restore the removed lines)
  2. Use a GitHub Action that handles commits (e.g., stefanzweifel/git-auto-commit-action)
  3. Configure git user via the actions/checkout action if it supports that in v6
      - name: Commit changes
        run: |
          # Add files that exist
          if [ -f rush.json ]; then git add rush.json; fi
          if [ -f common-versions.json ]; then git add common-versions.json; fi
          if [ -f common/config/rush/npm-shrinkwrap.json ]; then git add common/config/rush/npm-shrinkwrap.json; fi
          # Add all changes in common/scripts folder if it exists
          if [ -d common/scripts ]; then git add common/scripts/; fi
          if git diff --staged --quiet; then
            echo "No changes to commit."
          else
            git commit -m "chore: sync rush.json and regenerate lockfiles"
            git push
          fi

@nev21 nev21 enabled auto-merge (squash) December 30, 2025 06:18
@nev21 nev21 merged commit 955bba7 into main Dec 30, 2025
14 checks passed
@nev21 nev21 deleted the nev21-patch-1 branch December 30, 2025 06:20
@nev21
Copy link
Contributor Author

nev21 commented Dec 30, 2025

@copilot revert this PR

nev21 added a commit that referenced this pull request Dec 30, 2025
nev21 added a commit that referenced this pull request Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants