Additional steps to try and fix typedoc deployment #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nev21
commented
Dec 15, 2025
nev21
commented
- Update shrinkwrap
- Update shrinkwrap
There was a problem hiding this comment.
Pull request overview
This PR streamlines the GitHub Actions workflow for building and deploying TypeDoc documentation. The changes simplify the build process by removing redundant Rush commands and consolidating installation steps.
Key changes:
- Simplifies the build job by removing redundant Rush check and install commands
- Consolidates installation steps into a single
npm installcommand - Uses matrix node version variable instead of hardcoded value
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - name: Use Node.js ${{ matrix.node }} |
There was a problem hiding this comment.
The workflow references matrix.node but no matrix strategy is defined in the job configuration. This will cause the workflow to fail since the variable is undefined. Either add a matrix strategy definition or revert to the hardcoded node version.
| - run: node common/scripts/install-run-rush.js check | ||
| - run: node common/scripts/install-run-rush.js install | ||
| - run: npm run build --verbose | ||
There was a problem hiding this comment.
Line contains trailing whitespace which should be removed to maintain clean YAML formatting.
Suggested change
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.