Skip to content

Conversation

Copy link

Copilot AI commented Aug 22, 2025

Updated @rollup/plugin-commonjs and @rollup/plugin-node-resolve to their latest versions across all projects in the monorepo, and fixed TypeScript compatibility issues that were blocking the build.

Changes Made

  • @rollup/plugin-commonjs: Updated from ^25.0.7 to ^28.0.6
  • @rollup/plugin-node-resolve: Updated from ^15.2.3 to ^16.0.1
  • @types/node: Pinned to ^20.17.10 for TypeScript 4.9.x compatibility

Files Updated

  • /package.json (root)
  • /ts-plugin/package.json
  • /eslint-ts-plugin/package.json
  • /shared/package.json
  • common/config/rush/npm-shrinkwrap.json (dependency lockfile)

Issue Resolution

During the @rollup plugin upgrade, build failures were discovered that were caused by TypeScript version incompatibilities (not by the @rollup updates themselves). The project uses TypeScript 4.9.x, but transitive dependencies were pulling in @types/node@24.x which requires TypeScript 5.6+. This was resolved by explicitly pinning @types/node to version ^20.17.10 which is compatible with TypeScript 4.9.x.

Verification

  • ✅ Shared package builds and packages successfully with new @rollup versions
  • ✅ ts-plugin package builds and packages successfully with new @rollup versions
  • ✅ Rollup configurations are compatible with new plugin versions
  • ✅ Plugin imports and usage patterns remain unchanged
  • ⚠️ eslint-ts-plugin has pre-existing TypeScript errors with ESLint types (unrelated to this PR)

The existing rollup configurations in rollup.config.mjs files across all projects use standard plugin APIs that are maintained for backwards compatibility, ensuring a smooth upgrade path.

Fixes #316.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Author

Copilot AI commented Aug 22, 2025

@nev21 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copilot AI and others added 2 commits August 22, 2025 07:12
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump @rollup components Bump @rollup components to latest versions Aug 22, 2025
Copilot AI requested a review from nev21 August 22, 2025 07:17
@nev21
Copy link
Collaborator

nev21 commented Nov 18, 2025

@copilot investigate and fix the failures

Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Copy link
Author

Copilot AI commented Nov 18, 2025

@copilot investigate and fix the failures

Investigated and addressed the build failures.

Key findings:

  • The failures are NOT related to the @rollup plugin version bumps
  • The main issue was TypeScript 4.9.x incompatibility with @types/node 24.x (requires TS 5.6+)

Fixed in commit a03fa18:

  • Pinned @types/node to ^20.17.10 (compatible with TS 4.9.x) across all packages
  • ✅ shared package now builds successfully
  • ✅ ts-plugin package now builds successfully
  • ❌ eslint-ts-plugin has pre-existing TypeScript errors with ESLint types (unrelated to rollup bump)

The eslint-ts-plugin errors appear to be longstanding issues - recent CI runs going back months show the same failures. These ESLint type errors are a separate issue from the @rollup dependency updates.

Copilot AI changed the title Bump @rollup components to latest versions Bump @rollup components to latest versions and fix TypeScript compatibility Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump @rollup components

2 participants