Open
Conversation
Sync main to develop post 2.2.1
* Update EOS remote file copy commands
…TTPS) (#366) * Added remote_file_copy support for ASADevice (FTP, TFTP, SCP, HTTP, HTTPS). Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* Add remote file copy for cisco nxos devices
itdependsnetworks
requested review from
jeffkala,
pke11y and
pszulczewski
as code owners
jeffkala
reviewed
Apr 14, 2026
Contributor
There was a problem hiding this comment.
seems odd its file 2.2 but talking about v2.3 release.
jeffkala
reviewed
Apr 14, 2026
docs/user/lib_getting_started.md
Outdated
| #### Remote File Copy (Download to Device) | ||
|
|
||
| Some devices support copying files directly from a URL to the device. This is useful for larger files like OS images. To do this, you need to use the `FileCopyModel` data model to specify the source file information and then pass that to the `remote_file_copy` method. Currently only supported on Cisco IOS and Juniper Junos devices. Tested with ftp, http, https, sftp, and tftp urls. | ||
| Some devices support copying files directly from a URL to the device. This is useful for large files like OS images. To do this, you need to use the `FileCopyModel` data model to specify the source file information and then pass that to the `remote_file_copy` method. The model is currently supported on Cisco IOS, Juniper Junos, and Arista EOS devices. It has been tested with ftp, http, https, sftp, and tftp urls. |
Contributor
There was a problem hiding this comment.
ssupport ASA and nxos now too right? should we change to currently supported on Cisco and not mention NOS
jeffkala
reviewed
Apr 14, 2026
|
|
||
| def _uptime_to_string(self, uptime): | ||
| days = uptime / (24 * 60 * 60) | ||
| days = uptime // (24 * 60 * 60) |
Contributor
There was a problem hiding this comment.
answer will go for the next few code examples as well.
Contributor
Author
There was a problem hiding this comment.
apparently it rounds the number
>>> days = 1231231 // (24 * 60 * 60)
>>> days
14
>>> days = 1231231 / (24 * 60 * 60)
>>> days
14.250358796296297
jeffkala
reviewed
Apr 14, 2026
Contributor
jeffkala
left a comment
jeffkala
left a comment
There was a problem hiding this comment.
put a few things. Main one being release notes don't seem like they worked correctly its overwriting 2.2 vs creating new 2.3 file.
itdependsnetworks
force-pushed
the
release-2.3.0
branch
from
6a7d1dc to
917283a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.