Updates to the EOS driver based on PR comments from #365

[jtdub]

Summary

Addresses review comments from @gsnider2195 on PR #365. Resolves 12 items across eos_device.py and test_eos_device.py.

Production code (pyntc/devices/eos_device.py)

• Fail-fast validation: Scheme and query string checks moved before open()/enable() so invalid inputs error without connecting to the device.
• EOS hashing algorithm validation: get_remote_checksum now validates against an EOS-specific subset (md5, sha1, sha256, sha512) and raises a clear ValueError for unsupported algorithms.
• Checksum parsing simplified: Replaced regex with str.split("=") for parsing verify command output.
• Destination filename in copy commands: Both _build_url_copy_command_simple and _build_url_copy_command_with_creds now include the destination filename so URL-derived names (e.g., download) don't override the intended filename.
• Query string rejection: URLs with ? are rejected since EOS CLI cannot handle them.
• netloc for host:port: Replaced manual hostname/port construction with computed netloc.
• Credential routing simplified: Removed include_username parameter. Routing is now based on src.username: if None, uses the simple builder; otherwise uses the creds builder. Token-only auth (no username) correctly falls through to the simple builder.
• clean_url instead of download_url: Command builders use src.clean_url to prevent credential leakage.
• verify_file improvements: Early return when file doesn't exist; case-insensitive checksum comparison.
• Error detection extracted: Duplicate error-checking blocks consolidated into _check_copy_output_for_errors.
• Module-level constants: EOS_SUPPORTED_SCHEMES and EOS_SUPPORTED_HASHING_ALGORITHMS are now sets at module scope.

Tests (tests/unit/test_devices/test_eos_device.py)

• Removed hypothesis import block and all standalone @given/@pytest.mark.parametrize test functions.
• Consolidated into unittest.TestCase classes with self.assertRaises, self.assertEqual, and self.subTest.
• Removed duplicate TestRemoteFileCopyCommandExecution class (tests already covered by TestRemoteFileCopy).
• Removed stale # TODO: unit test for remote_file_copy.
• Added tests for unsupported scheme, query string rejection, and token-only auth routing.

Test plan

• poetry run python -m pytest tests/unit/test_devices/test_eos_device.py — 65 passed, 19 subtests passed
• poetry run ruff check — all checks passed

🤖 Generated with Claude Code

% source .env && poetry run pytest tests/integration/test_eos_device.py -v
===================================================================================== test session starts =====================================================================================
platform darwin -- Python 3.12.11, pytest-9.0.3, pluggy-1.6.0 -- /Users/jameswilliams/Library/Caches/pypoetry/virtualenvs/pyntc-gs002iVE-py3.12/bin/python
cachedir: .pytest_cache
rootdir: /Users/jameswilliams/Documents/code/pyntc
configfile: pyproject.toml
plugins: f5-sdk-3.0.21, requests-mock-1.12.1
collected 10 items

tests/integration/test_eos_device.py::test_device_connects PASSED                                                                                                                       [ 10%]
tests/integration/test_eos_device.py::test_check_file_exists_false PASSED                                                                                                               [ 20%]
tests/integration/test_eos_device.py::test_get_remote_checksum_after_exists PASSED                                                                                                      [ 30%]
tests/integration/test_eos_device.py::test_remote_file_copy_ftp PASSED                                                                                                                  [ 40%]
tests/integration/test_eos_device.py::test_remote_file_copy_tftp PASSED                                                                                                                 [ 50%]
tests/integration/test_eos_device.py::test_remote_file_copy_scp PASSED                                                                                                                  [ 60%]
tests/integration/test_eos_device.py::test_remote_file_copy_http PASSED                                                                                                                 [ 70%]
tests/integration/test_eos_device.py::test_remote_file_copy_https FAILED                                                                                                                [ 80%]
tests/integration/test_eos_device.py::test_remote_file_copy_sftp PASSED                                                                                                                 [ 90%]
tests/integration/test_eos_device.py::test_verify_file_after_copy PASSED                                                                                                                [100%]

The EOS device I'm testing against doesn't support the TLS version required by the server.

FAILED tests/integration/test_eos_device.py::test_remote_file_copy_https - pyntc.errors.FileTransferError: FileTransferError:
Error detected in copy command output:
cd `https://192.0.2.1/' [Waiting for response...]

% Error copying https://192.0.2.1/nautobot.png to flash: (
---- Connecting to 192.0.2.1 (192.0.2.1) port 8443
**** send: gnutls_handshake: A TLS fatal alert has been received.
**** recv: gnutls_handshake: A TLS fatal alert has been received.
cd: Fatal error: gnutls_handshake: A TLS fatal alert has been received.

see above for details
)

[jeffkala]

2 comments, but seems good for me

[jtdub]

Responding to @jeffkala's comments:

---

Re: _check_copy_output_for_errors readability (comment)

Good callout on readability, but the logic isn't quite the same — if output.lower() in ["error", "invalid", "failed"] checks if the entire output string equals one of those words. What we need is substring matching: does the output contain any of those words. For example, "% Error copying ftp://..." would not match with in, but does match with the any() approach.

---

Re: half-baked typing (comment)

Fair point. Adding type hints to the remote_file_copy signature in the next push.

[smk4664]

Thanks for fixing those issues I pointed out!