Skip to content

Replace older toml lib with current tomli #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-detiste wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace older toml lib with current tomli #2247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51d2d0f
replace usage of older "toml" with current "tomli"
a-detiste Nov 27, 2025
9d86279
Update error message in tasks.py
mjbear Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ pytest = "*"
pyyaml = "*"
pydocstyle = "*"
sphinx-rtd-theme = "*"
toml = "*"
tomli = "*"
yamllint = "*"
"ruamel.yaml" = "*"
mkdocs = "1.6.0"
Expand Down
7 changes: 4 additions & 3 deletions tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
from invoke import task

try:
import toml
import tomli
except ImportError:
sys.exit("Please make sure to `pip install toml` or enable the Poetry shell and run `poetry install`.")
sys.exit("Please make sure to `pip install tomli` or enable the Poetry shell and run `poetry install`.")


def strtobool(val: str) -> bool:
Expand Down Expand Up @@ -49,7 +49,8 @@ def is_truthy(arg):
return bool(strtobool(arg))


PYPROJECT_CONFIG = toml.load("pyproject.toml")
with open("pyproject.toml", "rb") as fd:
PYPROJECT_CONFIG = tomli.load(fd)
TOOL_CONFIG = PYPROJECT_CONFIG["tool"]["poetry"]

# Can be set to a separate Python version to be used for launching or building image
Expand Down