Security: Harden GitHub workflows and document accepted risks#13
Merged
Conversation
Changes: - ci.yml: Add explicit permissions, pin all action SHAs - release.yml: Pin all action SHAs to immutable commits - Add CodeQL config documenting accepted low-risk URL substring alerts Security hardening: - actions/checkout@11bd719 (v4.2.2) - actions/setup-python@a26af69 (v5.6.0) - codecov/codecov-action@18283e0 (v5.4.3) - actions/upload-artifact@ea165f8 (v4.6.2) - actions/download-artifact@d3f86a1 (v4.3.0) - softprops/action-gh-release@da05d55 (v2.2.2) - pypa/gh-action-pypi-publish@76f52bc (v1.12.4) Accepted risks documented in codeql-config.yml: - py/incomplete-url-substring-sanitization: Used for version detection only - py/overly-permissive-file: Test code operating on temp directories
CybotTM
force-pushed
the
security/fix-codeql-alerts
branch
from
0c0e9e8 to
e67954d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions: contents: read, pin all action SHAsSecurity Hardening
All GitHub Actions pinned to immutable commit SHAs:
actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683(v4.2.2)actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065(v5.6.0)codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24(v5.4.3)actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02(v4.6.2)actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093(v4.3.0)softprops/action-gh-release@da05d552573ad5aba039eaac05058a918a7bf631(v2.2.2)pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc(v1.12.4)Accepted Risks (Documented)
py/incomplete-url-substring-sanitization in catalog.py
py/overly-permissive-file in tests/test_bulk.py
Test Plan