Skip to content

feat: support event subscriptions#633

Merged
eduardoboucas merged 2 commits intomasterfrom
feat/event-subscriptions
Mar 16, 2026
Merged

feat: support event subscriptions#633
eduardoboucas merged 2 commits intomasterfrom
feat/event-subscriptions

Conversation

@eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas requested review from a team as code owners March 14, 2026 23:58
@netlify
Copy link

netlify bot commented Mar 14, 2026

Deploy Preview for open-api ready!

Name Link
🔨 Latest commit 660e243
🔍 Latest deploy log https://app.netlify.com/projects/open-api/deploys/69b5f68e1bdc2b000819f283
😎 Deploy Preview https://deploy-preview-633--open-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 571fae54-86ec-45a1-8b55-2e642f30f052

📥 Commits

Reviewing files that changed from the base of the PR and between 76de010 and 660e243.

📒 Files selected for processing (5)
  • go/models/function_config.go
  • go/porcelain/deploy.go
  • go/porcelain/deploy_test.go
  • go/porcelain/functions_manifest.go
  • swagger.yml

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Functions now support event subscriptions configuration. Developers can specify event subscriptions for functions through manifest files, defining which events each function should subscribe to. These subscriptions are automatically propagated through the deployment pipeline and exposed in the API schema, enabling seamless event-driven function architectures.

Walkthrough

This pull request adds support for event subscriptions in the function configuration system. The changes add a new EventSubscriptions field (of type []string) across the configuration stack: the FunctionConfig model, the manifest entry structure, and the API schema. The bundling logic is updated to read and propagate event subscriptions from the manifest into the function configuration. A test is added to verify the event subscriptions are correctly parsed and propagated from the manifest.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'feat: support event subscriptions' accurately summarizes the main change: adding support for event subscriptions across the codebase.
Description check ✅ Passed The pull request description references the related linear issue (RUN-2652) and is directly related to the changeset, which adds event subscription support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/event-subscriptions
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@eduardoboucas eduardoboucas merged commit ce4c688 into master Mar 16, 2026
15 checks passed
@eduardoboucas eduardoboucas deleted the feat/event-subscriptions branch March 16, 2026 08:54
eduardoboucas pushed a commit that referenced this pull request Mar 16, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.52.0](v2.51.0...v2.52.0)
(2026-03-16)


### Features

* support event subscriptions
([#633](#633))
([ce4c688](ce4c688))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants