Skip to content

Improve Type Safety in Form Submissions Handler #7857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Improve Type Safety in Form Submissions Handler #7857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64a7d9e
refactor(types): improve type safety in form submissions handler
google-labs-jules[bot] Jan 10, 2026
290fd30
Merge branch 'main' into jules-types-form-submissions-handler-8168542…
serhalp Jan 22, 2026
15ef330
fix(deps): pin @types/multiparty version
google-labs-jules[bot] Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
run: echo ${{ github.event.number }} > ./pr_number

- name: Upload deltas
uses: actions/upload-artifact@v6
uses: actions/upload-artifact@v5
with:
name: delta-action-deltas
retention-days: 7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
run: echo "shard=$(echo '${{ matrix.shard }}' | tr '/' '-')" >> $GITHUB_OUTPUT

- name: Store npm error artefacts
uses: actions/upload-artifact@v6
uses: actions/upload-artifact@v5
if: always()
with:
name: npm-logs--${{ matrix.os }}--${{ matrix.node-version }}--${{ steps.sanitize-shard-name.outputs.shard }}
Expand Down
17 changes: 0 additions & 17 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).


## [23.13.5](https://github.com/netlify/cli/compare/v23.13.4...v23.13.5) (2026-01-20)


### Bug Fixes

* **deps:** bump tar from 7.5.2 to 7.5.3 ([#7871](https://github.com/netlify/cli/issues/7871)) ([3e7c3a0](https://github.com/netlify/cli/commit/3e7c3a0583465815e4941be0f9eafe858159e657))
* **deps:** update netlify packages ([#7873](https://github.com/netlify/cli/issues/7873)) ([be07b3c](https://github.com/netlify/cli/commit/be07b3cc97f82b20bd5492fff1ccb863dd8b44ef))

## [23.13.4](https://github.com/netlify/cli/compare/v23.13.3...v23.13.4) (2026-01-17)


### Bug Fixes

* **deps:** bump h3 from 1.15.4 to 1.15.5 ([#7867](https://github.com/netlify/cli/issues/7867)) ([14eee2c](https://github.com/netlify/cli/commit/14eee2c661f8fe81c4554ed691a486c749ffd2dd))
* **types:** improve type safety in command helpers ([#7852](https://github.com/netlify/cli/issues/7852)) ([665fa01](https://github.com/netlify/cli/commit/665fa010ff3ee40e5eec825019afe62008bf293c))
* **types:** improve type safety in create-stream-promise util ([#7855](https://github.com/netlify/cli/issues/7855)) ([34d8a95](https://github.com/netlify/cli/commit/34d8a9529aca298e37a465b988c4a928746cd562))

## [23.13.3](https://github.com/netlify/cli/compare/v23.13.2...v23.13.3) (2026-01-08)


Expand Down
11 changes: 5 additions & 6 deletions e2e/install.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,10 @@
]

describe.each(installTests)('%s → installs the cli and runs commands without errors', (packageManager, config) => {
// Yarn v1 enforces engine constraints strictly. A transitive dep (chokidar@5) requires node >=20.19.0,
// breaking yarn installs on older Node 20.x. Node 20 EOL is April 2026, so we skip rather than override.
const yarnOnOldNode20 = packageManager === 'yarn' && process.versions.node === '20.12.2'
// TODO: Figure out why this flow is failing on Windows.
const npxOnWindows = platform() === 'win32' && 'run' in config

itWithMockNpmRegistry.skipIf(yarnOnOldNode20)('runs the commands without errors', async ({ registry }) => {
itWithMockNpmRegistry.skipIf(npxOnWindows)('runs the commands without errors', async ({ registry }) => {
// Install

const cwd = registry.cwd
Expand All @@ -218,7 +217,7 @@
reject: false,
})
if (installResult.exitCode !== 0) {
throw new Error(

Check failure on line 220 in e2e/install.e2e.ts

View workflow job for this annotation

GitHub Actions / E2E (macOS-latest, 20.12.2)

e2e/install.e2e.ts > yarn → installs the cli and runs commands without errors > runs the commands without errors 

Error: Install failed for yarn
Exit code: 1

yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
warning netlify-cli > node-fetch > fetch-blob > node-domexception@1.0.0: Use your platform's native DOMException instead
[2/4] Fetching packages...
error chokidar@5.0.0: The engine "node" is incompatible with this module. Expected version ">= 20.19.0". Got "20.12.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
 ❯ e2e/install.e2e.ts:220:13

Check failure on line 220 in e2e/install.e2e.ts

View workflow job for this annotation

GitHub Actions / E2E Windows tests (windows-2025, 20.12.2)

e2e/install.e2e.ts > yarn → installs the cli and runs commands without errors > runs the commands without errors 

Error: Install failed for yarn
Exit code: 1

Corepack is about to download https://registry.yarnpkg.com/yarn/-/yarn-1.22.22.tgz.
yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
warning netlify-cli > node-fetch > fetch-blob > node-domexception@1.0.0: Use your platform's native DOMException instead
[2/4] Fetching packages...
error chokidar@5.0.0: The engine "node" is incompatible with this module. Expected version ">= 20.19.0". Got "20.12.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
 ❯ e2e/install.e2e.ts:220:13

Check failure on line 220 in e2e/install.e2e.ts

View workflow job for this annotation

GitHub Actions / E2E (ubuntu-latest, 20.12.2)

e2e/install.e2e.ts > yarn → installs the cli and runs commands without errors > runs the commands without errors 

Error: Install failed for yarn
Exit code: 1

yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
warning netlify-cli > node-fetch > fetch-blob > node-domexception@1.0.0: Use your platform's native DOMException instead
[2/4] Fetching packages...
error chokidar@5.0.0: The engine "node" is incompatible with this module. Expected version ">= 20.19.0". Got "20.12.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
 ❯ e2e/install.e2e.ts:220:13
`Install failed for ${packageManager}\nExit code: ${installResult.exitCode.toString()}\n\n${
installResult.all || ''
}`,
Expand Down Expand Up @@ -304,9 +303,9 @@

describe.each(runTests)('%s → runs cli commands without errors', (packageManager, config) => {
// TODO: Figure out why this flow is failing on Windows.
const skipOnWindows = platform() === 'win32'
const npxOnWindows = platform() === 'win32' && 'run' in config

itWithMockNpmRegistry.skipIf(skipOnWindows)('runs commands without errors', async ({ registry }) => {
itWithMockNpmRegistry.skipIf(npxOnWindows)('runs commands without errors', async ({ registry }) => {
const [cmd, args] = config.run
const env = {
npm_config_registry: registry.address,
Expand Down
Loading
Loading