Skip to content

Additional props in dropdown #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kapantzak merged 3 commits into from
Jan 22, 2026
Merged

Additional props in dropdown #608

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe6cae5
Render select-all component in dropdown
kapantzak Jan 21, 2026
476b7cf
Minor fix
kapantzak Jan 21, 2026
4a1cba6
Change render prop name
kapantzak Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/components/drops/menu/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, { useMemo, useState, useRef } from "react"
import styled from "styled-components"
import { useVirtualizer } from "@tanstack/react-virtual"
import Flex from "@/components/templates/flex"
import { Text } from "@/components/typography"
import Search from "@/components/search"
import Box from "@/components/templates/box"
import { mergeRefs } from "@/utils"
Expand All @@ -15,6 +16,14 @@ const Container = styled(Flex)`

const defaultEstimateSize = () => 28

const DefaultNoSearchResultsComponent = () => {
return (
<Flex padding={[2, 0]} justifyContent="center">
<Text>No results were found</Text>
</Flex>
)
}

const Dropdown = ({
hideShadow,
itemProps,
Expand All @@ -26,12 +35,15 @@ const Dropdown = ({
Footer,
value,
hasSearch,
renderComponent,
searchMargin = [4],
gap = 0,
estimateSize = defaultEstimateSize,
close,
containerRef,
ref: forwardedRef,
showNoSearchResults = true,
NoSearchResultsComponent = DefaultNoSearchResultsComponent,
...rest
}) => {
const [searchValue, setSearchValue] = useState("")
Expand All @@ -41,7 +53,9 @@ const Dropdown = ({

const searchLowerCase = searchValue.toLowerCase()

return items.filter(({ label, value: val }) => {
return items.filter(({ label, value: val, customFiltering }) => {
if (typeof customFiltering === "function")
return customFiltering({ searchValue, label, value: val })
if (typeof label === "string" && label.toLowerCase().includes(searchLowerCase)) return true
if (!label && typeof val === "string" && val.toLowerCase().includes(searchLowerCase))
return true
Expand Down Expand Up @@ -80,6 +94,10 @@ const Dropdown = ({
<Search data-testid="dropdown-search" placeholder="Search" onChange={setSearchValue} />
</Box>
)}
{typeof renderComponent === "function" && renderComponent({ searchValue, filteredItems })}
{showNoSearchResults && filteredItems.length === 0 && searchValue ? (
<NoSearchResultsComponent />
) : null}
<div
ref={mergeRefs(ref, forwardedRef)}
style={{
Expand Down