fix(mcp): personal mode defaults all tools to Auto, toggle grants all (#942)#943
Merged
Aaronontheweb merged 3 commits intonetclaw-dev:devfrom May 8, 2026
Conversation
… tools (netclaw-dev#942) Personal audience now gets Auto approval and skips empty tool grants when adding a server (all tools pass by default). Toggling "Server enabled" in the TUI grants all discovered tools instead of starting empty. Uses TrustAudience enum instead of raw strings in ApplySecureDefaultsForNewServer.
Aaronontheweb
added
mcp
Disabling a server via ToggleServerAccess now clears pending grants for that audience so tools don't appear checked while the server is off.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Autoapproval and skips empty tool grants when adding a server vianetclaw mcp add— all tools pass by defaultnetclaw mcp permissionsTUI now grants all discovered tools instead of starting with an empty setTrustAudienceenum instead of raw strings inApplySecureDefaultsForNewServerCloses #942
Test plan
Add_WritesEmptyGrantsAndApprovalDefaultsAcrossAudiences— Personal getsAuto+ no grants; Team/Public unchangedAdd_WithGrantAll_SkipsGrantsButWritesApprovalDefaults— Personal approval isAutoAdd_DoesNotMutateExistingServers— Personal skips grants for new serverAdd_CreatesApprovalPolicySectionWhenMissing— Personal approval isAutoToggleServerAccess_GrantsAllDiscoveredTools— new test: enabling server grants all toolsMcpCommandTests+McpToolPermissionsViewModelTestspass