fix: add pipeline init gate to wrong-requester approval tests#941
Merged
Aaronontheweb merged 1 commit intonetclaw-dev:devfrom May 8, 2026
Merged
Conversation
The two wrong-requester tests were missing the CapturedOptions initialization wait that all other tests in the file use. On Windows CI, pipeline materialization can exceed the 3s default AwaitAssertAsync timeout, causing the first assertion to consume the entire budget before the actor even finishes initializing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Text_approval_from_wrong_requester_posts_warning(and siblingButton_approval_from_wrong_requester_posts_warning)AwaitAssertAsync(() => Assert.NotNull(pipeline.CapturedOptions))initialization gate that all 11 other tests inSessionBindingContractTestsuseAwaitAssertAsynctimeout, causing the first assertion to exhaust the entire budget before the actor finishes initializing — leaving no time for the second phase assertionObserved in PR #940 CI: https://github.com/netclaw-dev/netclaw/actions/runs/25565523273/job/75047844078
Test plan
Test-windows-latest)