Add slug filter to CustomObjectTypeFilterSet#527
Closed
Kani999 wants to merge 1 commit into
Closed
Conversation
Draft
GET /api/plugins/custom-objects/custom-object-types/?slug=foo previously
returned every COT — django-filter silently dropped the unrecognised
query parameter because the filterset's Meta.fields didn't include slug.
Adding slug to the tuple lets django-filter auto-generate the full
lookup family (exact, __ic, __isw, __regex, ...) backed by the
CustomObjectType.slug SlugField.
Verified via manage.py shell:
from netbox_custom_objects.filtersets import CustomObjectTypeFilterSet
'slug' in CustomObjectTypeFilterSet.base_filters
True
Side observation from PR netboxlabs#482's polymorphic smoke run on 2026-05-26.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Kani999
force-pushed
the
feature/cot-filterset-slug
branch
from
606ed8e to
7a0412d
Compare
Contributor
|
Hi @Kani999 -- please don't open a PR unless there is an accepted bug or feature issue to link it to. Please open a bug ticket first, then once it's triaged and accepted you can reopen this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/plugins/custom-objects/custom-object-types/?slug=foopreviously returned every Custom Object Type —django-filtersilently dropped the unrecognised query parameter becauseCustomObjectTypeFilterSet.Meta.fieldsdidn't includeslug. Addingslugto the tuple letsdjango-filterauto-generate the full lookup family (exact,__ic,__isw,__regex, ...) backed by theCustomObjectType.slugSlugField.Verification
Verified via
manage.py shell:After the change, all of these now narrow the result set:
?slug=vendor-policies?slug__ic=policies(icontains)?slug__isw=vendor(istartswith)Context
Surfaced during the related-object-tabs smoke test on 2026-05-26 (PR #482).