feat: regenerate ingester.py for NetBox 4.6 support#91
Merged
Conversation
Regenerated builder classes from diode-drf-extract PR #49 against a live NetBox 4.6.0 install. Adds Python SDK support for the four new NetBox 4.6 entity types — VirtualMachineType, CableBundle, RackGroup, ScriptModule — and the new flat-FK fields virtual_machine_type on VirtualMachine, bundle on Cable, group on Rack. Wire-compat is preserved at the proto layer (existing field numbers unchanged; refactored GFK oneof members get [deprecated = true] annotations in the underlying proto). Consumers using only the older shape continue to work. References the proto update in diode PR #528. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Follow-up to 20c97d0 (regenerated ingester.py). Adds: - `netboxlabs/diode/sdk/diode/v1/ingester_pb2.py`, `.pyi`, and `_grpc.py` regenerated via `buf generate --template buf.gen.sdk.py.yaml` from diode PR #528's updated proto, so `ingester_pb2.CableBundle`, `RackGroup`, `VirtualMachineType`, and `ScriptModule` are defined and `tests/test_ingester.py` / `tests/test_client.py` resolve their imports cleanly. - `docs/README.md` and `docs/examples/{cable_bundle,rack_group, script_module,virtual_machine_type}.py` propagated from diode-drf-extract `output/docs/python/`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
Documentation
Follow-up to 45003ee. The bindings regenerated via `buf generate --template buf.gen.sdk.py.yaml` use top-level Python import paths: from validate import validate_pb2 ... from diode.v1 import ingester_pb2 ... …but the SDK ships the validate bindings at `netboxlabs.diode.sdk.validate` and the ingester bindings at `netboxlabs.diode.sdk.diode.v1` (the prior bindings already used these fully-qualified paths). Without the rewrite, import-time fails with `ModuleNotFoundError: No module named 'validate'` and the entire test suite errors out during collection. Rewrites the two affected import lines in: - `netboxlabs/diode/sdk/diode/v1/ingester_pb2.py` - `netboxlabs/diode/sdk/diode/v1/ingester_pb2.pyi` - `netboxlabs/diode/sdk/diode/v1/ingester_pb2_grpc.py` Verified locally: `pytest tests/` reports 185 passed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||
jajeffries
approved these changes
May 15, 2026
leoparente
requested review from
MicahParks,
ltucker,
marc-barry and
mfiedorowicz
as code owners
samiura
approved these changes
May 18, 2026
mfiedorowicz
approved these changes
May 19, 2026
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates
netboxlabs/diode/sdk/ingester.pyagainst a live NetBox 4.6.0 install.What's new
Builder-class support for four new NetBox 4.6 entity types:
VirtualMachineTypeCableBundleRackGroupScriptModulePlus new flat-FK fields on existing classes:
VirtualMachine.virtual_machine_typeCable.bundleRack.groupThe
Entityunion gains the four new variants.Wire-compatibility
Preserved at the proto layer (see diode #528). Existing field numbers unchanged; refactored GFK
oneofmembers marked[deprecated = true]in the underlying proto. Existing Python builders for the legacy shapes continue to work.Related PRs
🤖 Generated with Claude Code