Fix counts for joined query builders #926
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getCount()so totals are de-duplicated likegetMany.Problem
SELECT COUNT(*) FROM (<join query>)for totals.totalItems/totalPagesand creating empty pages.Change
getCount(); TypeORM injects the same DISTINCT-on-PK logic used for paged selects.paginate.query.builder.distinct-count.spec.tsto prove joined queries now report correct totals.Side Effects / Compatibility
getCount()semantics (e.g., honorsgroupBythe same way TypeORM does) and still issues one count query plus one data query.