Skip to content

Conversation

@neotob
Copy link
Collaborator

@neotob neotob commented Mar 17, 2025

No description provided.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 17, 2025

Open in StackBlitz

npm i https://pkg.pr.new/neolution-ch/react-pattern-ui/@neolution-ch/react-pattern-ui@71

commit: 7e2e403

@neotrow neotrow requested a review from Copilot March 31, 2025 07:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project to ESLint 9 and associated neolution ESLint configuration while making minor code improvements and test updates.

  • Updates ESLint configuration and removes deprecated files.
  • Refactors code to address ESLint warnings (e.g., enforcing strict equality, switching from innerText to textContent).
  • Adjusts CI workflows to test on newer Node.js versions.

Reviewed Changes

Copilot reviewed 23 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/lib/Layout/PanelSideBarLayout/PanelSideBar/PanelSideBarToggle.tsx Added ESLint disable comment and improved equality check in classNames.
src/lib/Layout/PanelSideBarLayout/PanelSideBar/PanelSideBarItem.tsx Changed how child items are rendered from passing as a prop to rendering as nested children.
src/lib/Layout/PanelSideBarLayout/PanelSideBar/Definitions/PanelItem.ts Added disable comment to suppress import/named rule.
src/lib/Layout/PanelSideBarLayout/PanelSideBar/Context/PanelSideBarContext.tsx Refactored array operations for clarity.
rollup.config.mjs Updated import syntax and removed duplicate sourcemap configurations.
eslint.config.mjs, cypress/eslint.config.mjs Introduced new ESLint configuration using neolution config.
cypress/** Adjusted ESLint disables for tests and updated text property usage in tests.
.github/workflows/ci.yml Updated Node.js version matrix for CI.
.eslintrc.cjs & cypress/.eslintrc.cjs Removed obsolete ESLint configuration files.
CHANGELOG.md Documented the migration to ESLint 9.
Files not reviewed (5)
  • cypress/.eslintignore: Language not supported
  • cypress/cypress/support/component-index.html: Language not supported
  • cypress/package.json: Language not supported
  • cypress/styles/globals.css: Language not supported
  • package.json: Language not supported

Copy link
Contributor

@neotrow neotrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small things but lookgs great otherwise, thanks!

@neotrow neotrow merged commit 7f6d636 into main Jun 11, 2025
7 checks passed
@neotrow neotrow deleted the feature/eslint-9 branch June 11, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants