-
Notifications
You must be signed in to change notification settings - Fork 10
migrate to eslint 9 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the project to ESLint 9 and associated neolution ESLint configuration while making minor code improvements and test updates.
- Updates ESLint configuration and removes deprecated files.
- Refactors code to address ESLint warnings (e.g., enforcing strict equality, switching from innerText to textContent).
- Adjusts CI workflows to test on newer Node.js versions.
Reviewed Changes
Copilot reviewed 23 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/lib/Layout/PanelSideBarLayout/PanelSideBar/PanelSideBarToggle.tsx | Added ESLint disable comment and improved equality check in classNames. |
| src/lib/Layout/PanelSideBarLayout/PanelSideBar/PanelSideBarItem.tsx | Changed how child items are rendered from passing as a prop to rendering as nested children. |
| src/lib/Layout/PanelSideBarLayout/PanelSideBar/Definitions/PanelItem.ts | Added disable comment to suppress import/named rule. |
| src/lib/Layout/PanelSideBarLayout/PanelSideBar/Context/PanelSideBarContext.tsx | Refactored array operations for clarity. |
| rollup.config.mjs | Updated import syntax and removed duplicate sourcemap configurations. |
| eslint.config.mjs, cypress/eslint.config.mjs | Introduced new ESLint configuration using neolution config. |
| cypress/** | Adjusted ESLint disables for tests and updated text property usage in tests. |
| .github/workflows/ci.yml | Updated Node.js version matrix for CI. |
| .eslintrc.cjs & cypress/.eslintrc.cjs | Removed obsolete ESLint configuration files. |
| CHANGELOG.md | Documented the migration to ESLint 9. |
Files not reviewed (5)
- cypress/.eslintignore: Language not supported
- cypress/cypress/support/component-index.html: Language not supported
- cypress/package.json: Language not supported
- cypress/styles/globals.css: Language not supported
- package.json: Language not supported
neotrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small things but lookgs great otherwise, thanks!
No description provided.