Skip to content

Conversation

@dom-baur
Copy link
Contributor

Add utility function isValidSwissIbanNumber for issue #77

@dom-baur dom-baur requested a review from a team as a code owner August 27, 2025 13:27
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 27, 2025

Open in StackBlitz

npm i https://pkg.pr.new/neolution-ch/javascript-utils/@neolution-ch/javascript-utils@79

commit: 328ef6c

@neoscie neoscie requested a review from Copilot August 27, 2025 14:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new utility function isValidSwissIbanNumber to validate Swiss IBAN numbers according to the IBAN standard. The implementation includes input sanitization, format validation, and checksum verification using the mod-97 algorithm.

  • Implements Swiss IBAN validation with proper format checking and checksum calculation
  • Adds comprehensive test cases covering various valid and invalid IBAN scenarios
  • Updates changelog to document the new utility function

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/lib/string.ts Adds the isValidSwissIbanNumber function with IBAN validation logic
src/lib/string.spec.ts Adds test cases for the new IBAN validation function
CHANGELOG.md Documents the addition of the new utility function
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

neoscie and others added 2 commits August 27, 2025 16:05
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dom-baur dom-baur requested a review from neoscie August 27, 2025 14:32
@dom-baur dom-baur requested a review from drebrez August 28, 2025 07:05
@drebrez drebrez requested a review from fwermelinger September 3, 2025 12:44
drebrez
drebrez previously approved these changes Sep 3, 2025
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Package Line Rate Branch Rate Complexity Health
main 100% 100% 0
Summary 100% (188 / 188) 100% (95 / 95) 0

@fwermelinger fwermelinger enabled auto-merge (squash) September 3, 2025 13:18
@fwermelinger fwermelinger merged commit 89e87c1 into neolution-ch:main Sep 3, 2025
5 checks passed
@dom-baur dom-baur deleted the feature/isvalidswissibannumber branch September 3, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants