-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/eslint 9 #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/eslint 9 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
drebrez
reviewed
Feb 11, 2025
manni497
previously approved these changes
Feb 12, 2025
drebrez
reviewed
Feb 12, 2025
drebrez
reviewed
Feb 12, 2025
drebrez
reviewed
Feb 27, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the project's configuration to the new ESLint 9 flat config while making several related improvements in the build and test setups.
- Introduces a new eslint.config.mjs that imports and applies the flat config from @neolution-ch/eslint-config-neolution.
- Updates rollup.config.mjs for clearer import syntax and removes duplicate sourcemap properties.
- Refactors enum utility functions and improves error handling in localStorage alongside minor test adjustments.
- Removes the legacy .eslintrc.cjs file in favor of the new ESLint configuration.
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.mjs | Adds the new ESLint 9 flat config and customizes the unicorn/no-null rule |
| rollup.config.mjs | Updates the nodeResolve import style and removes duplicate sourcemap definitions |
| src/lib/enum.ts | Refactors enum utility functions by replacing findIndex with indexOf |
| CHANGELOG.md | Updates documentation to reflect the migration to ESLint 9 flat config |
| src/lib/localStorage.ts | Changes the thrown error to a TypeError for unsupported localStorage support |
| src/lib/localStorage.spec.ts | Refactors test for expiration by switching to Date.now |
| .eslintrc.cjs | Removes legacy ESLint configuration in favor of the new flat config |
Files not reviewed (2)
- .eslintignore: Language not supported
- package.json: Language not supported
|
manni497
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.