Skip to content

Conversation

@neotob
Copy link
Collaborator

@neotob neotob commented Feb 10, 2025

No description provided.

@neotob neotob requested a review from drebrez as a code owner February 10, 2025 09:26
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/neolution-ch/javascript-utils/@neolution-ch/javascript-utils@52

commit: 38378cc

manni497
manni497 previously approved these changes Feb 12, 2025
@neotrow neotrow requested a review from Copilot March 24, 2025 07:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project's configuration to the new ESLint 9 flat config while making several related improvements in the build and test setups.

  • Introduces a new eslint.config.mjs that imports and applies the flat config from @neolution-ch/eslint-config-neolution.
  • Updates rollup.config.mjs for clearer import syntax and removes duplicate sourcemap properties.
  • Refactors enum utility functions and improves error handling in localStorage alongside minor test adjustments.
  • Removes the legacy .eslintrc.cjs file in favor of the new ESLint configuration.

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eslint.config.mjs Adds the new ESLint 9 flat config and customizes the unicorn/no-null rule
rollup.config.mjs Updates the nodeResolve import style and removes duplicate sourcemap definitions
src/lib/enum.ts Refactors enum utility functions by replacing findIndex with indexOf
CHANGELOG.md Updates documentation to reflect the migration to ESLint 9 flat config
src/lib/localStorage.ts Changes the thrown error to a TypeError for unsupported localStorage support
src/lib/localStorage.spec.ts Refactors test for expiration by switching to Date.now
.eslintrc.cjs Removes legacy ESLint configuration in favor of the new flat config
Files not reviewed (2)
  • .eslintignore: Language not supported
  • package.json: Language not supported

@github-actions
Copy link

Package Line Rate Branch Rate Complexity Health
main 100% 100% 0
Summary 100% (110 / 110) 100% (58 / 58) 0

@drebrez drebrez requested a review from manni497 April 10, 2025 12:55
@manni497 manni497 merged commit 800dcfa into neolution-ch:main Apr 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants