-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade express from 4.17.1 to 4.22.1 #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade express from 4.17.1 to 4.22.1. See this package in npm: express See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/8ab66a5a-4d64-4272-b0f2-823ad2c32953?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the upgrade of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades express from 4.17.1 to 4.22.1, addressing several security vulnerabilities. This is a highly recommended update.
While this is a minor version bump and should be safe to merge, I'd like to point out two things for your consideration:
-
Potential Breaking Change:
express@4.20.0changed the defaultdepthfor parsing URL-encoded data fromInfinityto32. This is a security enhancement to prevent DoS attacks. Based onserver.ts, this is unlikely to affect your application, but it's important to be aware of. -
Code Improvement Suggestion: The file
server.ts(not part of this PR) usesrequire('body-parser'). Since Express v4.16.0,body-parser's functionality is built-in. I recommend replacingapp.use(bodyParser.json())withapp.use(express.json())in a future refactor. This will modernize your code and remove a fragile reliance on a transitive dependency.
Overall, the dependency upgrade is correct and significantly improves the project's security.
Snyk has created this PR to upgrade express from 4.17.1 to 4.22.1.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 15 versions ahead of your current version.
The recommended version was released a month ago.
Issues fixed by the recommended upgrade:
SNYK-JS-BODYPARSER-7926860
SNYK-JS-QS-14724253
SNYK-JS-QS-3153490
SNYK-JS-COOKIE-8163060
SNYK-JS-EXPRESS-6474509
SNYK-JS-EXPRESS-7926867
SNYK-JS-PATHTOREGEXP-7925106
SNYK-JS-PATHTOREGEXP-8482416
SNYK-JS-SEND-7926862
SNYK-JS-SERVESTATIC-7926865
Release notes
Package name: express
-
4.22.1 - 2025-12-01
- Release: 4.22.1 by @ UlisesGascon in #6934
-
4.22.0 - 2025-12-01
- Security fix for CVE-2024-51999 (GHSA-pj86-cfqh-vqx6)
- Refactor: improve readability by @ sazk07 in #6190
- ci: add support for Node.js@23.0 by @ UlisesGascon in #6080
- Method functions with no path should error by @ wesleytodd in #5957
- ci: updated github actions ci workflow by @ Phillip9587 in #6323
- ci: reorder
- Backport: ci: add node.js 24 to test matrix by @ Phillip9587 in #6506
- chore(4.x): wider range for query test skip by @ jonchurch in #6513
- use tilde notation for certain dependencies by @ UlisesGascon in #6905
- deps: qs@6.14.0 by @ UlisesGascon in #6909
- deps: use tilde notation for
- Release: 4.22.0 by @ UlisesGascon in #6921
-
4.21.2 - 2024-12-05
- Add funding field (v4) by @ bjohansebas in #6065
- deps: path-to-regexp@0.1.11 by @ blakeembrey in #5956
- deps: bump path-to-regexp@0.1.12 by @ jonchurch in #6209
- Release: 4.21.2 by @ UlisesGascon in #6094
-
4.21.1 - 2024-10-08
- Backport a fix for CVE-2024-47764 to the 4.x branch by @ joshbuker in #6029
- Release: 4.21.1 by @ UlisesGascon in #6031
-
4.21.0 - 2024-09-11
- Deprecate
- finalhandler@1.3.1 by @ wesleytodd in #5954
- fix(deps): serve-static@1.16.2 by @ wesleytodd in #5951
- Upgraded dependency qs to 6.13.0 to match qs in body-parser by @ agadzinski93 in #5946
- @ agadzinski93 made their first contribution in #5946
-
4.20.0 - 2024-09-10
- IMPORTANT: The default
- Remove link renderization in html while using
- 4.19.2 Staging by @ wesleytodd in #5561
- remove duplicate location test for data uri by @ wesleytodd in #5562
- feat: document beta releases expectations by @ marco-ippolito in #5565
- Cut down on duplicated CI runs by @ jonchurch in #5564
- Add a Threat Model by @ UlisesGascon in #5526
- Assign captain of encodeurl by @ blakeembrey in #5579
- Nominate jonchurch as repo captain for
- docs: update Security.md by @ inigomarquinez in #5590
- docs: update triage nomination policy by @ UlisesGascon in #5600
- Add CodeQL (SAST) by @ UlisesGascon in #5433
- docs: add UlisesGascon as triage initiative captain by @ UlisesGascon in #5605
- deps: encodeurl@~2.0.0 by @ blakeembrey in #5569
- skip QUERY method test by @ jonchurch in #5628
- ignore ETAG query test on 21 and 22, reuse skip util by @ jonchurch in #5639
- add support Node.js@22 in the CI by @ mertcanaltin in #5627
- doc: add table of contents, tc/triager lists to readme by @ mertcanaltin in #5619
- List and sort all projects, add captains by @ blakeembrey in #5653
- docs: add @ UlisesGascon as captain for cookie-parser by @ UlisesGascon in #5666
- ✨ bring back query tests for node 21 by @ ctcpip in #5690
- [v4] Deprecate
- skip QUERY tests for Node 21 only, still not supported by @ jonchurch in #5695
- 📝 update people, add ctcpip to TC by @ ctcpip in #5683
- remove minor version pinning from ci by @ jonchurch in #5722
- Fix link variable use in attribution section of CODE OF CONDUCT by @ IamLizu in #5762
- Replace Appveyor windows testing with GHA by @ jonchurch in #5599
- Add OSSF Scorecard badge by @ UlisesGascon in #5436
- update scorecard link by @ bjohansebas in #5814
- Nominate @ IamLizu to the triage team by @ UlisesGascon in #5836
- deps: path-to-regexp@0.1.8 by @ blakeembrey in #5603
- docs: specify new instructions for
- 4.x: Upgrade
- path-to-regexp@0.1.10 by @ blakeembrey in #5902
- @ marco-ippolito made their first contribution in #5565
- @ inigomarquinez made their first contribution in #5590
- @ mertcanaltin made their first contribution in #5627
- @ ctcpip made their first contribution in #5690
- @ bjohansebas made their first contribution in #5814
-
4.19.2 - 2024-03-25
-
4.19.1 - 2024-03-20
-
4.19.0 - 2024-03-20
-
4.18.3 - 2024-02-29
-
4.18.2 - 2022-10-08
-
4.18.1 - 2022-04-29
-
4.18.0 - 2022-04-25
-
4.17.3 - 2022-02-17
-
4.17.2 - 2021-12-17
-
4.17.1 - 2019-05-26
from express GitHub release notesWhat's Changed
Important
The prior release (4.22.0) included an erroneous breaking change related to the extended query parser. There is no actual security vulnerability associated with this behavior (CVE-2024-51999 has been rejected). The change has been fully reverted in this release.
Full Changelog: 4.22.0...v4.22.1
Important: Security
What's Changed
npm isteps to fix ci for older node versions by @ Phillip9587 in #6336qsby @ Phillip9587 in #6919Full Changelog: 4.21.2...4.22.0
What's Changed
Full Changelog: 4.21.1...4.21.2
What's Changed
Full Changelog: 4.21.0...4.21.1
What's Changed
"back"magic string in redirects by @ blakeembrey in #5935New Contributors
Full Changelog: 4.20.0...4.21.0
What's Changed
Important
depthlevel for parsing URL-encoded data is now32(previously wasInfinity)res.redirectOther Changes
http-errors,expressjs.com,morgan,cors,body-parserby @ jonchurch in #5587res.clearCookieacceptingoptions.maxAgeandoptions.expiresby @ jonchurch in #5672questionanddiscussby @ IamLizu in #5835merge-descriptorsdependency by @ RobinTail in #5781New Contributors
Full Changelog: 4.19.1...4.20.0
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: