Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion course-02/exercises/udacity-c2-restapi/package.json
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"dependencies": {
"@types/bcrypt": "^3.0.0",
"@types/jsonwebtoken": "^8.3.2",
"aws-sdk": "^2.492.0",
"aws-sdk": "^2.1693.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR updates the aws-sdk dependency in package.json, but the package-lock.json file has not been updated. Without updating the lock file, the dependency upgrade will not take effect in CI/CD environments or for other developers who clone the repository. Please run npm install to update package-lock.json and commit the changes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this upgrade within v2 of the AWS SDK is important for security, it's worth noting that AWS SDK for JavaScript v2 is in maintenance mode. AWS recommends migrating to v3 for new and existing projects to receive the latest features and updates. You should consider creating a plan to migrate to AWS SDK v3 to ensure the long-term health of this project. You can find more information in the AWS SDK for JavaScript v3 Developer Guide.

"bcrypt": "^5.0.0",
"body-parser": "^1.19.0",
"email-validator": "^2.0.4",
Expand Down