fix: stop printing Keycloak root password in cleartext during deploy#3217
Open
viniciusdc wants to merge 2 commits intomainfrom
Open
fix: stop printing Keycloak root password in cleartext during deploy#3217viniciusdc wants to merge 2 commits intomainfrom
viniciusdc wants to merge 2 commits intomainfrom
Conversation
Closes #3216 - Replace cleartext password in deploy log output with a generic '<set via config/env>' hint so users know the password is configured without leaking it to the terminal - Fix 'Kubecloak' typo in the log message
viniciusdc
requested review from
dcmcand and
marcelovilla
and removed request for
a team
When the password is provided via NEBARI_SECRET__ env var, mask it in the deploy output. When it comes from the config file or is auto-generated (e.g. first deploy), still print it so the user can retrieve it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/orgs/nebari-dev/discussions/3216
The deploy output was printing the Keycloak root password in cleartext, which is a security concern — especially when the password is injected via
NEBARI_SECRET__environment variables specifically to avoid having it in config files.Changes
src/_nebari/deploy.pyNEBARI_SECRET__security__keycloak__initial_root_passwordenv var, mask it in the deploy log with<set via env>Before / After