fix(aws): only validate KMS when eks_kms_arn is provided#3200
Open
0rlych1kk4 wants to merge 3 commits intonebari-dev:mainfrom
Open
fix(aws): only validate KMS when eks_kms_arn is provided#32000rlych1kk4 wants to merge 3 commits intonebari-dev:mainfrom
0rlych1kk4 wants to merge 3 commits intonebari-dev:mainfrom
Conversation
Author
|
Hi Nebari team, Thanks for the review! |
Author
|
Hi @dcmcand @marcelovilla Nebari team, Just a quick follow-up on this PR. The change ensures that KMS validation only runs when All checks have passed locally and in CI. Please let me know if any adjustments are needed — happy to update the PR. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Fixes #3059
What does this implement/fix?
This PR fixes AWS KMS validation in the infrastructure stage.
Previously,
amazon_web_services.kms_key_arns()was called even wheneks_kms_arnwas not set, which could:This change ensures KMS validation is performed only when
eks_kms_arnis explicitly provided.Existing behavior remains unchanged when the value is set.
Documentation
Not applicable.
Testing
How to test this PR?
eks_kms_arneks_kms_arnAny other comments?
This change avoids unnecessary AWS calls and improves reliability for deployments that do not use EKS encryption.