feat: table-aware JSON column detection for dot-notation syntax #57
+265
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, JSON path syntax (e.g., `containers[]`, `usage.cpu`) only worked for columns in the hardcoded DEFAULT_JSON_OBJECT_COLUMNS list (spec, status, labels, annotations, data, owner_references). This meant resource-specific JSON columns like `containers` in podmetrics weren't recognized. This change implements table-aware JSON column detection: - Add `ColumnDef::json()` constructor to explicitly mark JSON array/object columns - Update `get_core_resource_fields()` to use `json()` for 15+ array/object fields: rules, subjects, containers, usage, subsets, involved_object, source, etc. - Add `ResourceRegistry::get_json_columns()` and `get_json_columns_for_tables()` - Add `extract_table_names()` to parse FROM/JOIN clauses from SQL - Add `preprocess_sql_with_registry()` for table-aware preprocessing - Update `execute_sql()` to use the new preprocessing function Now queries like `SELECT containers[] FROM podmetrics` work correctly because: 1. Table name "podmetrics" is extracted from the query 2. Registry lookup finds containers has is_json_object=true 3. The `[]` syntax is recognized and converted to UNNEST(json_get_array(...)) This approach is table-aware - if another resource had a `containers` column that was a string, it wouldn't be incorrectly treated as JSON.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
containersin podmetrics,usagein nodemetrics) are correctly recognized for dot-notation and array expansion syntaxColumnDef::json()constructor and marks 15+ core resource fields as JSON arrays/objectsProblem
Previously,
SELECT containers[] FROM podmetricsdidn't work becausecontainerswasn't in the hardcodedDEFAULT_JSON_OBJECT_COLUMNSlist. Adding it to the hardcoded list would be incorrect since another resource could have acontainerscolumn that's a string.Solution
Table-aware detection:
is_json_object: trueTest plan
cargo test- 314 tests passcargo clippy- no warningsSELECT containers[] FROM podmetrics✅SELECT containers[].name FROM podmetrics✅SELECT usage.cpu FROM nodemetrics✅