Mission config#179
Merged
Merged
Conversation
- Only initialize once - Warn when it fails to initialize from the config file - Add minimal support for mission configuration from the config file - Path align - Gate (only the coinflip variant) *Making missions configurable from the config file comes at the cost of no longer using consts for these variables. The performance impact is probably negligible.
Contributor
|
Fixed merge conflicts. This should be ready to merge after testing at 06/14/2025 pool test. |
SarangaR
approved these changes
Jun 20, 2025
Contributor
SarangaR
left a comment
There was a problem hiding this comment.
Config working at latest pool test, cam paths are flipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the way the config file is handled:
Making a mission configurable means that we're no longer using consts for things like depths or speed, but the performance cost is probably negligible.
Based on #178