Add link icons #7
Conversation
| <a href="https://github.com/Sordamente"> | ||
| <img src="./images/github.svg" alt="github-logo"> | ||
| GitHub | ||
| </a> |
There was a problem hiding this comment.
What icon will be used for personal websites? Will we link to personal websites?
There was a problem hiding this comment.
Hmm, maybe the grey globe icon which is the default for websites?
There was a problem hiding this comment.
Yup that sounds good 👍🏼
| box-shadow: 0 5px 0 $theme-primary; | ||
|
|
||
| &:hover { | ||
| background-color: white; |
There was a problem hiding this comment.
Hover effect nonideal if the card doesn't do anything when clicked
There was a problem hiding this comment.
I think we can keep the hover, and add a popover to each card where the person can have a bio. Sort of like when you click on a person in discord? Keep the hover, either way - it adds dimension. Example is here, I think it looks good?
There was a problem hiding this comment.
Hmm, still seems to me that something should happen when clicked, but I guess we can add that in another PR
No description provided.