Skip to content

[18.0][MIG] auth_oauth_autologin: Migration to 18.0 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
natuan9 wants to merge 10 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] auth_oauth_autologin: Migration to 18.0 #3

natuan9 wants to merge 10 commits into from

Conversation

@natuan9
Copy link
Owner

@natuan9 natuan9 commented Nov 18, 2025 •
edited
Loading

No description provided.

@natuan9 natuan9 force-pushed the 18.0-mig-auth_oauth_autologin branch from 9602213 to 02c0826 Compare November 18, 2025 04:42
P-H-Phuc
P-H-Phuc suggested changes Nov 19, 2025
View reviewed changes
Copy link

@P-H-Phuc P-H-Phuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, there are a few changes:

P-H-Phuc
P-H-Phuc reviewed Nov 19, 2025
View reviewed changes
@P-H-Phuc
Copy link

P-H-Phuc commented Nov 19, 2025

You may consider squashing the commits to tidy up the history

@P-H-Phuc
Copy link

P-H-Phuc commented Nov 19, 2025

Please add your name to the CONTRIBUTORS.md file in readme folder

@P-H-Phuc
Copy link

P-H-Phuc commented Nov 19, 2025

I’m not fully confident about the changes in the config files of the server-auth repo. You may need to Sync fork with the latest OCA/server-auth:

image

natuan9 pushed a commit that referenced this pull request Nov 21, 2025
@paradoxxxzero
Merge pull request #3 from akretion/16.0-add-cross_connect_client-fdc…
7e18e52 
…-ref

[REF] avoid groupe deletion + simplify name management
@natuan9 natuan9 force-pushed the 18.0-mig-auth_oauth_autologin branch from 02c0826 to 181d14c Compare November 21, 2025 05:29
@natuan9
Copy link
Owner Author

natuan9 commented Nov 21, 2025

Hi @P-H-Phuc , thanks for your reviews, please help to review again

@P-H-Phuc
Copy link

P-H-Phuc commented Nov 21, 2025 •
edited
Loading

Hi @natuan9, since you created the https://github.com/OCA/server-auth/pull/863 , you’ll need to remove commit from the auth_oauth_autologin module in your fork.

@nilshamerlinck
Copy link

nilshamerlinck commented Nov 24, 2025

@P-H-Phuc to avoid creating links from OCA PRs to our internal PRs and OCA PRs, we usually use https://github.com/OCA/server-auth/pull/863 code style for links, thanks

@natuan9 natuan9 force-pushed the 18.0-mig-auth_oauth_autologin branch from 181d14c to c946385 Compare November 24, 2025 10:04
@natuan9 natuan9 requested a review from P-H-Phuc November 24, 2025 10:07
@P-H-Phuc
Copy link

P-H-Phuc commented Nov 24, 2025

Please check the pre-commit and you can try adding /* global window */ at the top of the JS file.

@natuan9 natuan9 force-pushed the 18.0-mig-auth_oauth_autologin branch from c946385 to 895538c Compare November 25, 2025 02:15
@natuan9
Copy link
Owner Author

natuan9 commented Nov 25, 2025

Hi @P-H-Phuc , please help to review

@natuan9 natuan9 force-pushed the 18.0-mig-auth_oauth_autologin branch 2 times, most recently from c637c01 to 8c3d84e Compare December 4, 2025 10:56
@natuan9 natuan9 force-pushed the 18.0-mig-auth_oauth_autologin branch from 8c3d84e to 7376795 Compare December 4, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@P-H-Phuc P-H-Phuc P-H-Phuc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@natuan9 @P-H-Phuc @nilshamerlinck @sbidoul @rousseldenis @benwillig @Loregs2 @mymage