Skip to content

upgrade PhoneNumberKit to v4 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliansteenbakker wants to merge 3 commits into
base: main
Choose a base branch
from
Open

upgrade PhoneNumberKit to v4 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74498aa
Update SwiftLibphonenumberPlugin.swift
juliansteenbakker Oct 16, 2024
1ef80d7
Update libphonenumber_plugin.podspec
juliansteenbakker Oct 16, 2024
3fa2d7c
imp: fix with latest version of utility
juliansteenbakker Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libphonenumber_plugin/ios/Classes/SwiftLibphonenumberPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import UIKit
import PhoneNumberKit

public class SwiftLibphonenumberPlugin: NSObject, FlutterPlugin {
let phoneNumberKit: PhoneNumberKit = PhoneNumberKit()

let phoneNumberKit: PhoneNumberUtility = PhoneNumberUtility()

public static func register(with registrar: FlutterPluginRegistrar) {
let channel = FlutterMethodChannel(name: "plugin.libphonenumber", binaryMessenger: registrar.messenger())
Expand Down Expand Up @@ -125,7 +125,7 @@ public class SwiftLibphonenumberPlugin: NSObject, FlutterPlugin {
let phoneNumber = arguments["phoneNumber"] as! String
let isoCode = arguments["isoCode"] as! String

let partialFormatter: PartialFormatter = PartialFormatter(phoneNumberKit: phoneNumberKit, defaultRegion: isoCode.uppercased())
let partialFormatter: PartialFormatter = PartialFormatter(utility: phoneNumberKit, defaultRegion: isoCode.uppercased())

let formattedNumber = partialFormatter.formatPartial(phoneNumber)

Expand Down
2 changes: 1 addition & 1 deletion libphonenumber_plugin/ios/libphonenumber_plugin.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ A new flutter plugin project.
s.source = { :path => '.' }
s.source_files = 'Classes/**/*'
s.dependency 'Flutter'
s.dependency 'PhoneNumberKit'
s.dependency 'PhoneNumberKit', '~> 4.0'

s.platform = :ios, '12.0'

Expand Down