Skip to content

fix: prevent flaky tests by disabling parallel execution for registry tests #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natemcmaster merged 1 commit into from
Jan 12, 2026
Merged

fix: prevent flaky tests by disabling parallel execution for registry tests #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/CommandLineUtils.Tests/RemainingArgsPropertyConventionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

namespace McMaster.Extensions.CommandLineUtils.Tests
{
// Uses shared static CommandMetadataRegistry - must not run in parallel with other registry tests
[Collection("MetadataRegistry")]
public class RemainingArgsPropertyConventionTests : ConventionTestBase
{
public RemainingArgsPropertyConventionTests(ITestOutputHelper output) : base(output)
Expand Down
2 changes: 2 additions & 0 deletions test/CommandLineUtils.Tests/SourceGeneration/CommandMetadataRegistryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

namespace McMaster.Extensions.CommandLineUtils.Tests.SourceGeneration
{
// Uses shared static CommandMetadataRegistry - must not run in parallel with other registry tests
[Collection("MetadataRegistry")]
public class CommandMetadataRegistryTests
{
[Command(Name = "test1")]
Expand Down
2 changes: 2 additions & 0 deletions test/CommandLineUtils.Tests/SourceGeneration/ConventionAotPathTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ namespace McMaster.Extensions.CommandLineUtils.Tests.SourceGeneration
/// Tests for the AOT-friendly code paths in conventions.
/// These tests exercise the generated metadata paths in conventions.
/// </summary>
// Uses shared static CommandMetadataRegistry - must not run in parallel with other registry tests
[Collection("MetadataRegistry")]
public class ConventionAotPathTests : IDisposable
{
public ConventionAotPathTests()
Expand Down
2 changes: 2 additions & 0 deletions test/CommandLineUtils.Tests/SourceGeneration/MetadataProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

namespace McMaster.Extensions.CommandLineUtils.Tests.SourceGeneration
{
// Uses shared static CommandMetadataRegistry - must not run in parallel with other registry tests
[Collection("MetadataRegistry")]
public class MetadataProviderTests
{
[Command(Name = "test", Description = "A test command")]
Expand Down
Loading