Fix #987: Add length validation for CFE_EVS_SEND_HK_MID in ProcessCommandPacket#988
Open
linerfan5114 wants to merge 1 commit into
Open
Fix #987: Add length validation for CFE_EVS_SEND_HK_MID in ProcessCommandPacket#988linerfan5114 wants to merge 1 commit into
linerfan5114 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #987
Added CFE_EVS_VerifyCmdLength check before processing SEND_HK_MID in CFE_EVS_ProcessCommandPacket(). This matches the existing pattern used in CFE_EVS_ProcessGroundCommand() for all other command codes, and prevents OOB reads from malformed/truncated packets.
Same fix pattern as #971 (TIME) and #986 (ES).