edslib runtime lib improved portability#114
Open
mabeh19 wants to merge 2 commits into
Open
Conversation
jphickey
reviewed
May 14, 2026
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
| int32_t Result = 0; | ||
| int32_t Char1 = 0; | ||
| int32_t Char2 = 0; | ||
|
|
Contributor
There was a problem hiding this comment.
Char1 and Char2 should be int here as opposed to int32_t (this is the type needed for ctype.h macros)
Also remove init to 0 because its done later from string data (static analysis will complain about this)
Author
There was a problem hiding this comment.
good observation, has been adjusted accordingly
|
|
||
| Char1 = (int32_t)String1[Index]; | ||
| Char2 = (int32_t)String2[Index]; | ||
|
|
Contributor
There was a problem hiding this comment.
Can we move this before the "if" and then compare Char1 and Char2 rather than String1[Index] (more readable, I think)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Removed non standard C library headers, replaced
strcasecmpwith local helper function.Testing performed
Built on Windows using VS2026, cmake and MSVC
Built on Linux using cmake and gcc
Tested new local helper against strcasecmp. See end of PR for list of comparisons
Checked with CppCheck with flags
--enable=all --check-level=exhaustiveExpected behavior changes
No impact to behavior.
System(s) tested on
Windows 11 Home 25H2, build 26200.8246
Xubuntu 24.04.3 LTS x86_64 VMWare Virtual machine, kernel 6.17.0-22-generic
Contributor Info - All information REQUIRED for consideration of pull request
Mathias Ingeman Behrens, Personal
Tested comparisons