Skip to content

Fix: use Random.Shared instead of new Random() per call #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
narayan24 merged 1 commit into from
May 15, 2026
Merged

Fix: use Random.Shared instead of new Random() per call #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MainWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,7 +1129,7 @@
catch { }
}

private void LogError(string message, string detail = null)

Check warning on line 1132 in MainWindow.xaml.cs

View workflow job for this annotation

GitHub Actions / build (Debug) 

Cannot convert null literal to non-nullable reference type.

Check warning on line 1132 in MainWindow.xaml.cs

View workflow job for this annotation

GitHub Actions / build (Release) 

Cannot convert null literal to non-nullable reference type.
{
try
{
Expand Down Expand Up @@ -4026,7 +4026,7 @@
// — Randomness —

public static int RandomInt(int min, int max)
=> new Random().Next(min, max + 1);
=> Random.Shared.Next(min, max + 1);

// — Clothing —

Expand Down
Loading