feat(applicationsets): apply portal-committed tenant manifests (portal-tenants)#22
Merged
Merged
Conversation
…l-tenants) The portal's write path renders charts/tenant and commits one manifest per tenant to tenants/<cluster>/<tenant>.yaml in the tenants GitOps repo, but no ApplicationSet consumed that repo — apps-tenants deploys the per-tenant *app charts*, not the Platform/BudgetPolicy/Tenant boundary manifests. So portal-created tenants were committed but never applied: ArgoCD had nothing watching them. Add the portal-tenants ApplicationSet: a git directory generator over tenants/* applies each per-cluster directory (recurse). repoURL must equal the portal worker's GITOPS_TENANTS_REPO_URL. Static-validated; live-verify on the first portal-driven EKS deploy (the kx rehearsal applied the rendered manifest directly, since kx ArgoCD is idle by design).
CI Results
All validations passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The portal commits one tenant manifest per tenant to
tenants/<cluster>/<tenant>.yaml, but no ApplicationSet consumed that repo —apps-tenantsdeploys the per-tenant app charts, not the Platform/BudgetPolicy/Tenant boundary manifests. So portal-created tenants were committed but never applied. Addsportal-tenants: a git directory generator overtenants/*applies each per-cluster dir. repoURL must equal the portal'sGITOPS_TENANTS_REPO_URL. Static-validated; live-verify on the first portal-driven EKS deploy (kx ArgoCD is idle, so the A2 rehearsal applied the rendered manifest directly).